docs: explain Settings navigation and Billing tabs - #135
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![mogplex[bot]](https://avatars.githubusercontent.com/in/3107927?s=60&v=4){kind=small}
There was a problem hiding this comment.
Mogplex PR Review
Status: Attention needed
Docs-only PR that rewrites Settings navigation (secondary sidebar + per-section pages) and documents the Billing Settings / Usage tabs. The new content is accurate and internally coherent on routes, and the legacy-redirect table additions line up with the Settings page table. No security or correctness risks — it is prose and tables only.
Non-blocking accuracy gaps, all inside files this PR touches:
- content/docs/web/settings.mdx renames "Access Tokens" to "Mogplex Keys" in the "What lives here" list, but the detailed section further down is still titled "## Access Tokens" and never mentions the new label or the new Provider Keys page, so the same doc uses two names for one surface.
- The old "What lives here" list documented "Preferences for theme and default model"; the new list and the Settings pages table drop Preferences entirely, yet the later "Preferences and Models" section still asserts "Settings owns account preferences". A reader cannot tell which page now holds theme/default model.
- content/docs/plans-and-billing.mdx still links to the unscoped https://mogplex.com/settings/billing while the PR documents scoped routes (/<scope>/settings/billing) and the legacy table only lists scoped redirects — worth confirming the unscoped URL still resolves post-deploy.
- The legacy-routes table gained rows for account/teams/keys/billing/members/models/audit but nothing for the new MCP Servers page (/<scope>/settings/mcp); if an older tab pointed there, the map is incomplete.
- Out of diff but now stale by this rename: content/docs/web/models.mdx still says "Settings ... use the Models section" and "Settings for account preferences, access tokens, and models". Noted only, not a blocker.
Hygiene is good: the description explains the why, lists validation, and correctly gates merge on Mogplex/mogplex#520 shipping — that gate should be honored so the docs do not describe undeployed UI.
4 findings were added inline.
Suggestions
- Related page not updated with the new Settings vocabulary (content/docs/web/models.mdx)
Outside the diff, content/docs/web/models.mdx still says "Open Settings and use the Models section" and lists "Settings for account preferences, access tokens, and models" in Read next. Since this PR establishes that Models has its own sidebar destination and that tokens are now "Mogplex Keys", those lines read as stale after merge. Not a blocker for this PR, but a good follow-up (or a small addition here).
| - **Account** shows GitHub identity, App coverage, account access, and **Run checks**. | ||
| - **Teams** lists team memberships and controls. | ||
| - **Provider Keys** stores keys for model providers. | ||
| - **Mogplex Keys** manages tokens for CLI, API, and script access. |
There was a problem hiding this comment.
Warning: Settings doc uses two names for the same surface (Mogplex Keys vs Access Tokens)
The "What lives here" list now says "Mogplex Keys manages tokens for CLI, API, and script access", and the pages table adds /<scope>/settings/mogplex-keys plus a separate /<scope>/settings/keys for Provider Keys. But the detail section later in the same file is still titled "## Access Tokens" and opens with "Access tokens are for authenticating Mogplex clients and scripts" — it never mentions the new label, and there is no matching detail section for the new Provider Keys page.
A reader scanning for "Mogplex Keys" will not find it, and the "Access Tokens" heading now contradicts the navigation the PR is documenting.
Suggestion: rename the heading to "Mogplex Keys" with a one-line note that this was previously called Access Tokens, and add a short "Provider Keys" section covering model-provider credentials so both new pages have detail to match the table.
| - **Preferences** for theme and default model | ||
| - **Run checks**, one switch for the automatic judgments Mogplex makes about | ||
| agent work | ||
| - **Account** shows GitHub identity, App coverage, account access, and **Run checks**. |
There was a problem hiding this comment.
Warning: Preferences (theme, default model) dropped from the page list but still referenced later
The removed list included "Preferences for theme and default model". The new "What lives here" list and the Settings pages table have no Preferences entry, yet the "Preferences and Models" section further down still states "Settings owns account preferences."
After the sidebar split, readers need to know which page holds theme and default-model preferences — presumably Account, but the doc does not say. Was the omission intentional?
Suggestion: if preferences moved under Account, extend the Account bullet (e.g. "Account shows GitHub identity, App coverage, account access, preferences for theme and default model, and Run checks") and update the "Preferences and Models" section to name the page.
| Use this guide to choose a plan and understand each charge. For current account | ||
| details, open [Settings → Billing](https://mogplex.com/settings/billing). | ||
|
|
||
| Use **Billing Settings** for the plan, payments, invoices, and credit purchases. |
There was a problem hiding this comment.
Suggestion: Unscoped billing link may not match the new scoped routes
The added tab guidance sits directly under the existing link to https://mogplex.com/settings/billing, while this PR documents billing as scoped (/<scope>/settings/billing) and the legacy-route table only lists scoped redirects. Please confirm the unscoped /settings/billing URL still resolves after the app deploy; if it only works via a scope-inference redirect, that is worth a row in the legacy table.
| | Older route | Current destination | Best doc page | | ||
| | --- | --- | --- | | ||
| | `/<scope>/settings` | Personal **Account** or team **Members** page | [Settings](/web/settings) | | ||
| | `/<scope>/settings?tab=account`, `?tab=teams`, or `?tab=keys` | The matching `/<scope>/settings/<section>` page | [Settings](/web/settings) | |
There was a problem hiding this comment.
Suggestion: Legacy route map has no row for the new MCP Servers page
The new rows cover account, teams, keys, billing, members, models, and audit, but the Settings pages table also introduces MCP Servers at /<scope>/settings/mcp. If an older tab or hash (for example ?tab=mcp) pointed at MCP server definitions, the redirect map is incomplete for it. If MCP server definitions previously lived only under the connections tab, a short clarifying note would prevent readers from assuming the page is new-only.
There was a problem hiding this comment.
Mogplex PR Review
Status: Attention needed
Docs-only PR that rewrites the Settings page around the new secondary sidebar, adds the Billing Settings / Usage tab split, and extends the legacy-route map. The new content is internally coherent (routes in content/docs/web/settings.mdx match the redirect table in content/docs/web/guides/legacy-routes.mdx, and the old #access-tokens anchor is preserved with an explicit span), so there are no critical issues.
Main gap is incomplete propagation of the rename. The PAT surface is now documented as "Mogplex Keys" at //settings/mogplex-keys, but content/docs/reference/api.mdx (Quickstart and Authentication) and content/docs/mcp/install.mdx still tell users to go to "Settings → API Keys", a label that exists nowhere in the new Settings page list. Similarly, content/docs/plans-and-billing.mdx only got two of its Billing references qualified with the new tab names; the invoices, payment-method, add-on, and "Recent usage costs" sections still say plain "Billing".
Also note the PR depends on Mogplex/mogplex#520; claims such as the back arrow, mobile nav behavior, and //settings/billing?tab=usage cannot be verified from this repo, so merge ordering after the app deploy matters as the description states.
3 findings were added inline.
Warnings
- PAT docs still point to "Settings → API Keys", a section this PR removes (content/docs/reference/api.mdx)
content/docs/reference/api.mdx tells users to "Create a personal access token in Mogplex → Settings → API Keys" (Quickstart) and to "Revoke or replace a token from Settings → API Keys" (Authentication). After this PR, the Settings pages table in content/docs/web/settings.mdx lists Account, Teams, Provider Keys, Mogplex Keys, MCP Servers, and Billing — there is no "API Keys" section, and Mogplex Keys is the page that "manages tokens for CLI, API, and script access" at //settings/mogplex-keys.
The mismatch predates this PR (the old page called it "Access Tokens"), but this is the rename PR, so it is the natural place to fix it. Suggest updating both mentions to Settings → Mogplex Keys and linking to /web/settings#access-tokens (the anchor you preserved) so readers land on the right section.
- MCP install guide repeats the stale "Settings → API Keys" path (content/docs/mcp/install.mdx)
In the "Personal access token fallback" section, content/docs/mcp/install.mdx says to "create a personal access token in Mogplex → Settings → API Keys". Same issue as content/docs/reference/api.mdx: that label no longer maps to any page in the new Settings sidebar. Update to Settings → Mogplex Keys (//settings/mogplex-keys) for consistency with the page this PR rewrites.
|
|
||
| Mogplex shows recent usage costs in Billing. These costs use the available | ||
| Mogplex shows recent usage costs in **Billing → Usage**. These costs use the available | ||
| inference-credit balance. |
There was a problem hiding this comment.
Warning: Billing tab split applied inconsistently in plans-and-billing.mdx
The intro now states Billing Settings owns plan/payments/invoices/credit and Usage owns balance and recent usage costs, and two call sites were updated ("Settings → Billing → Billing Settings" for adding credit, "Billing → Usage" for hosted usage rates). The rest of the page still says plain "Billing":
- "Parallel agent runs": "Billing shows the plan limit…" and "Billing shows these recurring add-ons" (Billing Settings)
- "Storage add-ons": "Billing shows the new limit, monthly change…" (Billing Settings)
- "Payment methods and invoices": "Billing shows the latest 20 invoices" (Billing Settings), and "Usage charges appear in Recent usage costs" — per the new intro that surface is on the Usage tab, so it should be qualified as Billing → Usage → Recent usage costs
- "Check the selected account" callout: "Confirm the account name at the top of Billing"
Either qualify each of these with the owning tab or state once near the top that unqualified "Billing" means the Billing Settings tab. Half-qualified references are more confusing than none.
| @@ -3,10 +3,43 @@ title: Settings | |||
| description: Manage GitHub identity, App coverage, access keys, account preferences, and billing. | |||
| --- | |||
There was a problem hiding this comment.
Suggestion: settings.mdx frontmatter description and residual single-page framing are now stale
Minor cleanups in content/docs/web/settings.mdx:
- The frontmatter description still reads "…access keys, account preferences, and billing". "Account preferences" moved to the user menu in this PR, and "access keys" is ambiguous now that Provider Keys and Mogplex Keys are distinct pages.
- "## Use this page to fix account problems, not routing logic" and the "Billing and Access" prose ("The Billing section shows the monthly plan cost, next due date, … recent invoices") still describe Settings as one page and do not use the new tab split, partially duplicating the new "## Billing" section above.
| ## Where to see models | ||
|
|
||
| Open [Settings](/web/settings) and use the **Models** section. | ||
| Open **Models** in the main sidebar. |
There was a problem hiding this comment.
Suggestion: models.mdx: dangling antecedent after the sidebar rewording
"Open Models in the main sidebar." is now followed by "That section is the product-facing model catalog." With the Settings framing gone, "That section" has no clear referent. Suggest "The Models page is the product-facing model catalog."
Mogplex PR ReviewStatus: No material issues found Summary Documentation-only change across 6 MDX files. The rewrite is internally consistent and the cross-references check out. Approve-ready, with the merge-ordering caveat the author already noted (depends on Mogplex/mogplex#520 shipping first). What I verified
Suggestions (non-blocking)
Verdict ✅ APPROVE — accurate, well-scoped docs update; merge after the corresponding app change is deployed so the instructions match production. Affected files:
|
This branch was successfully deployed
1 participant
Settings now uses a secondary sidebar with separate personal and team pages. Document the page URLs, legacy redirects, mobile navigation, and the Billing Settings and Usage tabs. Update the Run checks directions to use pages instead of tabs.
Depends on Mogplex/mogplex#520. Merge after the app is deployed so the instructions match production.
Validation: lint, type checks, 18 tests, and production build passed. Checked the new directions against the app's scoped routes and browser tests.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.