docs: place MCP Servers under Connections - #136
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Mogplex PR Review
Status: Attention needed
Docs-only PR that moves MCP Servers from the Settings sidebar into a Connections tab. The three edited pages (connections-and-mcp.mdx, legacy-routes.mdx, settings.mdx) are internally consistent with each other: the Settings route table and "What lives here" list drop the MCP row, the tab URL /<scope>/connections?tab=mcp is documented once with history behavior, and the legacy-route table gains a row covering /<scope>/settings/mcp, ?tab=mcp, and #mcp. No security, correctness, or dependency surface is touched.
One gap: the web app overview page still describes Settings as having an MCP servers page, so after this PR the docs contradict themselves. Details in the finding below. Everything else is a minor polish suggestion; nothing here blocks merge once the dependent app deployment lands (the PR description already sequences that correctly).
Evidence checked: base-ref legacy-routes.mdx confirmed the previous "MCP Servers keeps its route at //settings/mcp" wording is fully replaced; settings.mdx read end-to-end for leftover MCP-in-Settings claims (none remain); configure-and-extend/index.mdx and content/docs/index.mdx contain only scope-neutral MCP references and need no edit.
Warnings
- web/index.mdx still lists MCP servers as a Settings page (content/docs/web/index.mdx)
The web app overview was not updated with the rest of the move. It still says:
"Settings opens a secondary sidebar with separate pages for account, teams, keys, MCP servers, and billing. Billing has Billing Settings and Usage tabs."
That directly contradicts this PR, which removes MCP Servers | /<scope>/settings/mcp from the Settings route table in content/docs/web/settings.mdx and states the surface now lives in Connections. A reader landing on /web will still go hunting in the Settings sidebar.
Suggested fix: drop MCP servers from that sentence so it reads "separate pages for account, teams, keys, and billing", matching the updated table in settings.mdx. Optionally add MCP Servers to the existing **Connections**-related bullet, or leave it to the settings.mdx pointer this PR adds.
I checked the other overview/index pages for the same problem: content/docs/configure-and-extend/index.mdx and content/docs/index.mdx only reference MCP generically (the /mcp endpoint card and section blurbs), so they do not need changes.
Suggestions
- Settings page's Connections section omits the new two-tab layout (content/docs/web/settings.mdx)
The updated "What lives here" list now points readers to Connections → MCP Servers, but the longer## Connectionssection further down this same page still describes the page as a single surface ("quick-add MCP presets", "fully custom REST or MCP endpoints", etc.) with no mention of the Integrations/MCP Servers split thatconnections-and-mcp.mdxintroduces.
A one-line addition after "This page now lives at /<scope>/connections, outside Settings." — e.g. noting the Integrations and MCP Servers tabs and the ?tab=mcp URL — would keep the two pages telling the same story. Low priority, since the canonical description lives in connections-and-mcp.mdx.
- "Old links preserve unrelated query values" is vague for the redirect map (content/docs/web/guides/legacy-routes.mdx)
In the replacement paragraph, "Old links preserve unrelated query values" is hard to act on next to a table whose other rows spell out exactly what survives a redirect ("with checkout return messages preserved", "with OAuth and Slack return messages preserved").
If the app behavior is that query params other than tab/sub are carried over to /<scope>/connections?tab=mcp, saying that explicitly (or giving one short example) would match the precision of the surrounding rows. Only worth doing if you can confirm the behavior from the dependent app PR.
Mogplex PR ReviewStatus: No material issues found Docs-only change that relocates MCP Servers from the Settings sidebar into a Connections tab. All six edits are internally consistent, the new link target exists, and no stale "MCP under Settings" wording remains in the adjacent CLI, MCP, or API docs I checked. What I verified:
Non-blocking notes:
Verdict: APPROVE — accurate, consistent docs update with no correctness or security surface; only merge timing is a dependency. Affected files:
|
MCP Servers now lives in Connections beside Integrations, rather than in the Settings sidebar. Update the operating guide and Settings/legacy-route docs with the tab URL, browser history behavior, and redirects for old MCP links.
Depends on Mogplex/mogplex#521. Merge after the app deployment so these directions match production.
Validation: lint, typecheck, 18 tests and production build passed through the required repository hooks. No schema or configuration changes.
Need help on this PR? Tag
@codesmith-botwith what you need. Autofix is disabled.