Two follow-ups from the Mogplex review of #542:
findingKey in lib/workflows/pr-review-self-revision.ts matches a draft finding by severity, path, and line. If a draft finding had no line and the revision adds one, the whole revision is discarded. Nothing breaks: the draft is published and the publish-time rewrite still runs. But a danglingReference draft then loses the one revision only its author could write. Treat a missing draft line as matching any line, and add a test for it.- The default
judgeReviewFormat in lib/workflows/automation-job-agent-runners-shared.ts isn't exercised by any test. That default sets the decision scope and the { job_run_id, pr_number, stage: "reviewer_draft" } metadata. Move the metadata into a small exported helper and pin it, so a renamed flow_job_run_id or a dropped stage tag fails CI.
Two follow-ups from the Mogplex review of #542:
findingKeyinlib/workflows/pr-review-self-revision.tsmatches a draft finding by severity, path, and line. If a draft finding had nolineand the revision adds one, the whole revision is discarded. Nothing breaks: the draft is published and the publish-time rewrite still runs. But adanglingReferencedraft then loses the one revision only its author could write. Treat a missing draftlineas matching any line, and add a test for it.judgeReviewFormatinlib/workflows/automation-job-agent-runners-shared.tsisn't exercised by any test. That default sets the decision scope and the{ job_run_id, pr_number, stage: "reviewer_draft" }metadata. Move the metadata into a small exported helper and pin it, so a renamedflow_job_run_idor a dropped stage tag fails CI.