Repository navigation
chore(lane): daily maintenance 2026-11-07 - #1274
Merged
Merged
Conversation
What was stale: docs/PRODUCT_MAP.md did not know the core server commands that #1269 added — the `core_cmds` locale area was missing from the list of areas, the moon-remote code map entry described only server setup and station administration, and the Connections feature row had no word on the commands. What the code does now: a core whose address is a non-loopback literal IPv4 (settings/connections/core_menu.rs `eligible`) gets a right-click menu with status, retry login, log, restart/stop/start, and — only for a core MoonTerminal installed (`MenuForm::Ours`) — exchange, API keys, showing the connection key, MoonProto address and update; without a server login the menu offers to add one (`MenuForm::NoLogin`); a cached server status reporting a failed exchange login shows a Retry banner on the card (connections/cores.rs). Verified by reading those sources, backend/core_cmds/model.rs and locales/en/core_cmds.en.yml. Reviewed by Codex; its three corrections (loopback excluded, the connection key is shown not changed, the banner needs the server status) are applied.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Docs
docs/PRODUCT_MAP.mddid not know the core server commands that #1269 added:core_cmdslocale area was missing from the list of areas; themoon-remotecode-map entry described only server setup and station administration; the Connections row of
the feature map had no word on the commands.
(
settings/connections/core_menu.rseligible) gets a right-click menu with status, retrylogin, log, restart/stop/start, and — only for a core MoonTerminal installed
(
MenuForm::Ours) — exchange, API keys, showing the connection key, MoonProto address andupdate; without a server login the menu offers to add one; a cached server status reporting a
failed exchange login shows a Retry banner on the card (
connections/cores.rs).backend/core_cmds/model.rsandlocales/en/core_cmds.en.yml. Reviewer: Codex — its three corrections (loopback excluded, theconnection key is shown not changed, the banner needs the server status) are applied.
Documents read in rotation:
docs/PRODUCT_MAP.md(drift found and fixed).Quiet jobs
cargo deny check advisories bans sourcesgreen onorigin/main5e02faa.auto-foundissue carriesneeds-human.finding filed as Report ProfitAbs removes leverage twice on cores whose spentbtc is the notional #1273 (ProfitAbs removes leverage twice on notional-basis cores), no fix in
this pull request.