Repository navigation
chore(lane): daily maintenance 2026-11-03 - #140
Merged
Merged
Conversation
Filed by the fix lane. Fixes #138 function_body_uses_param matched the parameter as a substring, so a builder taking `_id` and calling `with_identity()` read as using it and escaped the noop_public_api_markers count. It now counts a mention only when neither neighbouring character is `_` or ASCII alphanumeric. Test: function_body_usage_matches_whole_identifiers_only in xtask/src/component_audit/source_metrics/tests.rs failed before with `assertion failed: !function_body_uses_param(&unused, 0, "_id")` and passes now. Re-run: cargo test -p xtask function_body_usage cargo xtask component-audit --check-baseline still passes (no builder newly counted). Reviewer: Codex (PASS, no objections).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
Filed by the fix lane.
Fixes #138
function_body_uses_param(xtask/src/component_audit/source_metrics.rs) matched a builder parameter as a substring, so a builder taking_idwhose body callswith_identity()read as using it and escaped thenoop_public_api_markerscount. It now counts a mention only when neither neighbouring character is_or ASCII alphanumeric.function_body_usage_matches_whole_identifiers_onlyinxtask/src/component_audit/source_metrics/tests.rsfailed before withassertion failed: !function_body_uses_param(&unused, 0, "_id")and passes now. Re-run:cargo test -p xtask function_body_usage.cargo xtask component-audit --check-baselinestill passes: no builder in the current tree is newly counted.Quiet jobs
docs/PALETTE_SPEC.md,docs/COMPONENT_AUDIT.md,crates/moon-gpui/README.mdandcrates/moon-ui-gallery/README.mdchecked against the code; all current.d5baf53,f12793a(fix(input): apply MoonInput placeholder to an external state #137) and6a64da2reviewed; no demonstrable defect.