Repository navigation
feat(gpui): expose the inspector's element map of the last frame - #142
Merged
Merged
Conversation
Add `Window::inspector_hitboxes()` and `InspectorHitbox`: every element the inspector could pick in the last rendered frame, in paint order, with its inspector id (global id path and source location), its bounds and the content mask it was drawn under. Picking mode already gives every non-transparent div a hitbox and records its inspector id, but only in `pub(crate)` frame fields. A tool that wants the whole screen therefore had to hover each element and wait for the inspector to name it, one frame per element. With the map public it reads the whole frame at once. Additive and behind `debug_assertions`, like the rest of the inspector API; outside picking mode the list is empty.
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
Window::inspector_hitboxes()andInspectorHitbox: every element the inspector could pick in the last rendered frame, in paint order, with its inspector id (global id path and source location), its bounds and the content mask it was drawn under.Picking mode already registers a hitbox and an inspector id for every non-transparent div, but only in
pub(crate)frame fields, so a tool that needs the whole screen had to hover each element and wait a frame for the inspector to name it. MoonTerminal's UI scene capture reads the whole frame at once through this method.debug_assertionslike the rest of the inspector API; outside picking mode the list is empty.window::tests::the_inspector_map_lists_every_div_of_a_picking_frame_in_paint_order(catches readingnext_frame, losing paint order, or filling outside picking mode).tools/run-component-guardrails.ps1PASS,cargo test -p moon-gpuigreen.