feat: add Newton CUDA graph owner knob - #1605
Merged
Merged
Conversation
Collaborator
Author
|
Full-budget FlashSAC Newton validation completed on the current owner-knob head ( Environment: RTX 4090, Warp reports CUDA mempool enabled. The graph run emitted no fallback warning. Both runs used seed 1, 2048 environments, 25000 iterations, AMP, and the canonical
Command: uv run --no-sync train --algo flashsac --task g1_motion_tracking --sim newton \
env.newton_use_cuda_graph=true training.no_play=trueArtifacts:
The graph snapshot records |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EnvCfg.newton_use_cuda_graphowner knob with bool validation and factory forwarding.unisim-core>=1.6.0in the standard and ROCm dependency profiles and update both lockfiles.Consumes the published
unisim-core 1.6.0release (unilabsim/unisim#144, released through #147).Validation
uv run pytest -q tests/base/backend/test_newton_backend_options.py tests/base/test_isaacgym_fixed_variants.py tests/envs/locomotion/g1/test_g1_owner_contract.py tests/scripts/test_train_scripts.py::test_offpolicy_flashsac_g1_motion_tracking_task_composes- 7 passed, 33 deselecteduv lock --checkpyproject.rocm.tomlanduv.rocm.lockmake checkmake test-all- 1491 passed, 27 skipped, 598 deselected; benchmark smoke 34/34 module mode and 35/35 script mode3402c8f: +48.57% final SPS, -35.77% wall time, reward parity.Drives #1604.