Skip to content

fix: align genesis probe parallel level - #1606

Merged
TATP-233 merged 1 commit into
mainfrom
fix/issue-1604-genesis-probe
Sep 17, 2026
Merged

TATP-233 merged 1 commit into
mainfrom
fix/issue-1604-genesis-probe

Conversation

@TATP-233

@TATP-233 TATP-233 commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Temporarily set GS_PARA_LEVEL=2 around SAC/TD3/FlashSAC runner construction when training.sim_backend is genesis.
  • The one-env learner probe now compiles the same Genesis/Quadrants kernel lane as the scaled collector; the prior value or unset state is restored before runner.learn().
  • Other backends remain untouched. This is a cold-start mitigation and does not change the collector-ready root fix or claim new convergence evidence.

Linked Work

Validation

  • make test-all passed on the final local head before this PR was created or updated
  • Additional task-specific validation listed below

Commands actually run:

uv run pytest tests/scripts/test_train_scripts.py -k "genesis_probe_para_level"
# 147 deselected because this file is in the slow lane; rerun below with -m slow
uv run pytest tests/scripts/test_train_scripts.py -m slow -k "genesis_probe_para_level"
# 3 passed, 144 deselected
uv run ruff format --check src/unilab/scripts/train_offpolicy.py tests/scripts/test_train_scripts.py
uv run ruff check src/unilab/scripts/train_offpolicy.py tests/scripts/test_train_scripts.py
make check
make test
# Initial run failed during collection before optional extras were installed.
make sync
make test
# Initial clean-worktree run had two missing Allegro asset-cache failures.
uv run unilab-pull-assets --robot allegro_hand
uv run pytest tests/base/test_sim_backend_smoke.py::test_mujoco_backend_fixed_base_dof_views_do_not_skip_first_joint tests/base/test_sim_backend_smoke.py::test_motrix_backend_fixed_base_base_views_are_available -m "not slow"
# 2 passed
make test
# 1485 passed, 28 skipped, 601 deselected
make test-all
# 1485 passed, 28 skipped, 601 deselected; benchmark smoke module-mode 34/34 and script-mode 35/35
uv run pytest tests/scripts/test_check_docs.py -q
# 19 passed
cd docs/sphinx && UNILAB_DOCS_SKIP_AUTODOC=1 uv run --no-project --with-requirements requirements.txt sphinx-build -b html -n source build/html
# build succeeded
git diff --check

Remote CI route:

Impact

  • Backend impact: genesis
  • Platform impact: Linux
  • Training effect expected: yes, reduced first-run Genesis cold JIT/cache mismatch; no reward-parity claim

Artifacts

  • W&B: none
  • benchmark result: none
  • video / screenshot: none
  • ONNX / checkpoint: none

Checklist

  • Added or updated tests where needed
  • Updated docs if behavior or workflow changed
  • Linked the driving issue
  • Noted any follow-up work explicitly

@TATP-233
TATP-233 requested a review from caozx1110 as a code owner September 17, 2026 09:50
@TATP-233
TATP-233 merged commit 1483c2e into main Sep 17, 2026
8 checks passed
@TATP-233
TATP-233 deleted the fix/issue-1604-genesis-probe branch September 17, 2026 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant