fix: consume released unisim portable scenes - #1610
Merged
Merged
Conversation
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
unisim-core>=1.7.1and locks the public PyPI sdist.PORTABLE_MJCF_PROFILE_IDdirectly and exercises the portable robot/passive-object/table/mirror fixture without a local UniSim checkout or provisional skip._portable_modeboundary, uses Genesis' exact supported contact form, and matches IsaacSim worker dependency isolation plus its explicit contact-sensor diagnostic.User-facing training behavior is unchanged; this consumes the corrected released portable-scene runtime.
Linked Work
v1.7.1mainReleased Artifact
unisim-core==1.7.1d9a26a8cbf239cc6ae1b3dde35bcb6b844efd71ac2b23c86037d644c18780338superdex-physics-uni==1.1.0,superdex-robotics-uni==1.1.0Validation
make test-allpassed on the final local head before this PR was created or updatedCommands actually run on final head
7c59c739:Real IsaacSim evidence: NVIDIA GeForce RTX 4090, driver 595.84, IsaacSim 5.1.0.0, IsaacLab 0.47.2, external Python 3.11 worker, host
unisim-core==1.7.1. Both passive/non-passive parameterizations passed from the public package withUNILAB_LOCAL_UNISIMremoved.Remote CI route:
main: current-head remote CI was required and passed.7c59c739: success — https://github.com/Motphys/UniLab/actions/runs/354261687327c59c739: success — https://github.com/Motphys/UniLab/actions/runs/35426168790Impact
Artifacts
make test-allsmoke imports passedChecklist
No UniSim or UniLab
maincheckout or commit was made; all work stayed on child/roadmap branches and PRs.