Skip to content

Repair embedded-runtime CI contract findings - #42

Draft
MrScripty wants to merge 6 commits into
fix/rustfmt-repair-stack-2026-10-03from
fix/embedded-runtime-ci-contracts-2026-10-03
Draft

MrScripty wants to merge 6 commits into
fix/rustfmt-repair-stack-2026-10-03from
fix/embedded-runtime-ci-contracts-2026-10-03

Conversation

@MrScripty

@MrScripty MrScripty commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

Repairs the embedded-runtime area exposed by the strict aggregate Clippy gate, preserving the earlier repair stack through PR41.

Separately reviewed milestones:

  • Mechanical defaults, borrow and match cleanup, with the full default-feature embedded unit suite added to required focused CI.
  • Private transparent artifact-write failure payload indirection, preserving exact Display and the concrete WorkflowServiceError source/downcast contract without changing sink Result signatures.
  • Private package-facts and snapshot indirection, preserving raw DTOs, source selection and clone isolation.

Validation: pinned full cargo fmt passes locally and at the preceding hosted head. At b73c5d1, actual embedded execution passed 449 tests including the new concrete source-chain tests, with three failures retained: one deferred-reservation lifecycle fixture and two production-facts validation/publication fixtures. Clippy improved from 13 to 6 embedded findings. Current head 788ce31 has fresh Quality, Headless and Runtime Separation runs pending; no local Rust build is claimed.

The full embedded suite remains required. Remaining private/public arity work and fixture corrections will be separately reviewed commits here. Production dependency audit and frontend critical-lint fixes remain on PR21/PR22 for final integration. No merge qualification or complete external review is claimed.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant