Skip to content

Propagate shutdown failures and complete strict Rust qualification - #43

Draft
MrScripty wants to merge 7 commits into
fix/embedded-runtime-ci-contracts-2026-10-03from
fix/uniffi-shutdown-result-2026-10-03
Draft

MrScripty wants to merge 7 commits into
fix/embedded-runtime-ci-contracts-2026-10-03from
fix/uniffi-shutdown-result-2026-10-03

Conversation

@MrScripty

@MrScripty MrScripty commented Oct 3, 2026 •

Copy link
Copy Markdown
Owner

UniFFI discarded the fallible embedded shutdown result, making a failed backend stop appear successful. Return Result<(), FfiError> through the existing JSON error envelope with the original cause. Twelve Rust callers now handle the result, and real FFI→embedded→gateway tests cover failure, retained readiness, retry and repeated success. Generated C# callers retain await Shutdown() syntax and gain FfiException propagation; no C# shutdown-failure injection is claimed.

The subsequent strict Rust qualification repairs preserve behavioral assertions while resolving mechanical/test findings. The desktop commands now group injected Tauri State values through operation-specific CommandArg implementations, preserving managed identity, extraction order, original wire keys, ACL references and flat payloads. Five real MockIPC tests each execute exactly once. Separate mechanical, IPC and pinned-format milestone commits preserve review history.

At b2490ae, full formatting, no-default/all-feature workspace checks, five MockIPC tests, Rust doc tests, BEAM smoke, frontend tests, ESLint and typecheck passed. Headless and Runtime Separation passed; Headless includes 893 workflow-service tests, 13 artifact-store tests, 12/27 UniFFI tests and generated/packaged C# qualification. The focused ledger target exposed an E0597 temporary-lifetime regression in a test helper; the reviewed follow-up uses direct any on the named mutable iterator with unchanged short-circuit and row-error behavior. Fresh ledger/focused and strict Clippy qualification for that correction remains pending.

Root reviewed each source milestone and independently verified final pinned formatting. Stacked on PR42. Known critical frontend and production dependency audit failures await the separately reviewed PR21/PR22 siblings and their ancestry in the final combined tree. No merge readiness or complete main-relative external review is claimed.

@coderabbitai

coderabbitai Bot commented Oct 3, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MrScripty MrScripty changed the title Propagate runtime shutdown failures through UniFFI Propagate shutdown failures and complete strict Rust qualification Oct 3, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant