Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UniFFI discarded the fallible embedded shutdown result, making a failed backend stop appear successful. Return Result<(), FfiError> through the existing JSON error envelope with the original cause. Twelve Rust callers now handle the result, and real FFI→embedded→gateway tests cover failure, retained readiness, retry and repeated success. Generated C# callers retain await Shutdown() syntax and gain FfiException propagation; no C# shutdown-failure injection is claimed.
The subsequent strict Rust qualification repairs preserve behavioral assertions while resolving mechanical/test findings. The desktop commands now group injected Tauri State values through operation-specific CommandArg implementations, preserving managed identity, extraction order, original wire keys, ACL references and flat payloads. Five real MockIPC tests each execute exactly once. Separate mechanical, IPC and pinned-format milestone commits preserve review history.
At b2490ae, full formatting, no-default/all-feature workspace checks, five MockIPC tests, Rust doc tests, BEAM smoke, frontend tests, ESLint and typecheck passed. Headless and Runtime Separation passed; Headless includes 893 workflow-service tests, 13 artifact-store tests, 12/27 UniFFI tests and generated/packaged C# qualification. The focused ledger target exposed an E0597 temporary-lifetime regression in a test helper; the reviewed follow-up uses direct any on the named mutable iterator with unchanged short-circuit and row-error behavior. Fresh ledger/focused and strict Clippy qualification for that correction remains pending.
Root reviewed each source milestone and independently verified final pinned formatting. Stacked on PR42. Known critical frontend and production dependency audit failures await the separately reviewed PR21/PR22 siblings and their ancestry in the final combined tree. No merge readiness or complete main-relative external review is claimed.