Repository navigation
Conversation
botanical
reviewed
Aug 14, 2026
| * @ividito | ||
| * @slesaad | ||
| * @smohiudd | ||
| * @NASA-IMPACT/veda-data-services |
jjfrench
force-pushed
the
chore/uv-support
branch
from
October 14, 2026 22:27
137f132 to
2c60345
Compare
Contributor
Author
|
✅ completed a self review and didn't see anything obvious; let me know if I should change anything |
botanical
reviewed
Oct 27, 2026
botanical
reviewed
Oct 27, 2026
botanical
requested changes
Oct 27, 2026
botanical
left a comment
Member
There was a problem hiding this comment.
Should all the calls to python scripts be updated too with uv run? Like
veda-data/.github/workflows/pr.yml
Line 149 in c9d7ef2
response=$(python3 "$script_to_run" "$file" "staging")
should change to
response=$(uv run --locked --group scripts python "$script_to_run" "$file" "staging")
?
botanical
reviewed
Oct 27, 2026
botanical
reviewed
Oct 27, 2026
botanical
reviewed
Oct 27, 2026
botanical
approved these changes
Oct 27, 2026
botanical
left a comment
Member
There was a problem hiding this comment.
Sorry I have one last suggestion! But everything looks good to me
jjfrench
force-pushed
the
chore/uv-support
branch
from
October 28, 2026 01:16
557fdf8 to
a39e85f
Compare
Contributor
Author
|
Sorry @botanical, can I get one more review post-rebase? |
botanical
approved these changes
Oct 30, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://github.com/NASA-IMPACT/veda-architecture/issues/836
Description
Also addressed: