Skip to content

Rename SymmCldImpact function per latest UFO code change(#431) - #435

Open
jim-p-w wants to merge 1 commit into
release/4.0.0from
feature/4.0.0-pr431
Open

Rename SymmCldImpact function per latest UFO code change(#431)#435
jim-p-w wants to merge 1 commit into
release/4.0.0from
feature/4.0.0-pr431

Conversation

@jim-p-w

@jim-p-w jim-p-w commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

Description

Following JCSDA-internal/ufo#4148 (merged on 7/13/26), the SymmCldImpactIR ObsFunction was renamed to SymmCldImpact. This PR accounts for that change, so tests running model verification using ABI and AHI won't fail.

This is a cherry-pick of PR 431

Issue closed

Closes #(if applicable)

Tests completed

Tier 1:

  • 3dvar_OIE120km_WarmStart
  • 3denvar_OIE120km_IAU_WarmStart
  • 3dvar_OIE120km_ColdStart
  • 3dvar_O30kmIE60km_ColdStart
  • 3denvar_O30kmIE60km_WarmStart
  • eda_OIE120km_WarmStart
  • getkf_OIE120km_WarmStart
  • ForecastFromGFSAnalysesMPT
  • 4denvar_OIE120km_WarmStart
  • 4dhybrid_OIE120km_WarmStart

Tier 2 (optional):

  • GenerateGFSAnalyses
  • GenerateObs

Stack created with GitHub Stacks CLIGive Feedback 💬

### Description
Following [JCSDA-internal/ufo#4148](JCSDA-internal/ufo#4148) (merged on 7/13/26), the `SymmCldImpactIR` ObsFunction was renamed to `SymmCldImpact`. This PR accounts for that change, so tests running model verification using ABI and AHI won't fail.

### Issue closed
None

### Tests completed
#### Tier 1:
 - [x] 3dvar_OIE120km_WarmStart
 - [x] 3denvar_OIE120km_IAU_WarmStart
 - [x] 3dvar_OIE120km_ColdStart
 - [x] 3dvar_O30kmIE60km_ColdStart
 - [x] 3denvar_O30kmIE60km_WarmStart
 - [x] eda_OIE120km_WarmStart
 - [x] getkf_OIE120km_WarmStart
 - [x] ForecastFromGFSAnalysesMPT
 - [x] 4denvar_OIE120km_WarmStart
 - [x] 4dhybrid_OIE120km_WarmStart
@jim-p-w
jim-p-w added this pull request to stack #437 September 9, 2026 20:54
@jim-p-w jim-p-w self-assigned this Sep 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants