Run Linter workflow on PRs to any branch, add build step - #445
Merged
Conversation
Previously the Linter workflow only triggered on PRs targeting master, but most PRs target master-dev, so it was effectively never running. Also add a build step so a PR that breaks webpack compilation is caught before merge, not just at manual publish time. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
master, but nearly all PRs targetmaster-dev, so it was effectively never running on real PRs.npm run dev) so a PR that breaks webpack compilation is caught in CI, not just at manual dev/prod publish time.Test plan
npm run lintstill passes locally (exit 0)npm run lintcorrectly flags a deliberately introduced error (tested and reverted)npm run devbuilds successfully locally🤖 Generated with Claude Code