Tasking: offer "open in a new window" when there's no Beacon Remote tab - #456
Merged
Merged
Conversation
When openURLInBeacon can't reuse a Beacon Remote tab (none registered, or it was closed), the warning alert now includes a link that opens the target URL in a new window. Also guards against an undefined sendMessage response. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
OSPFNeighbour
force-pushed
the
fix/tasking-open-in-new-window-fallback
branch
from
September 9, 2026 06:26
94f64c5 to
fc8facd
Compare
OSPFNeighbour
changed the base branch from
refactor/beaconclient-core
to
master-dev
September 9, 2026 06:26
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
When Tasking tries to open a URL in the Beacon Remote tab (
openURLInBeacon) and there's no tab to reuse — none registered, or it was closed — the warning alert now:target="_blank" rel="noopener noreferrer").Also guards against an undefined
sendMessageresponse (previously threw onresponse.message).Changes
chromeRunTime.js— reason mapping + link + click-to-dismiss.windowAlert.js—showAlertreturns the alert id; newcloseAlert(id)helper (the timeout path reuses it).Testing
npx eslintclean on both files.🤖 Generated with Claude Code