fix(cli): preserve Linux venv lib64 aliases - #1110
Draft
afourniernv wants to merge 1 commit into
Draft
afourniernv wants to merge 1 commit into
afourniernv wants to merge 1 commit into
Conversation
Signed-off-by: Alex Fournier <afournier@nvidia.com>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueComment |
Contributor
Author
|
/nvskills-ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Linux virtual environments normally contain a root
lib64 -> libsymlink. Dynamic Python plugin attestation currently traverses that alias as a second copy and can reject a physically sub-512 MiB environment as oversized. Activation snapshots also expand the alias instead of preserving it.Details
lib64 -> libvenv alias while continuing to hash both logical paths.pyvenv.cfgidentifies the venv root.Where should the reviewer start?
Start with
python_environment_byte_budget_counts_internal_directory_alias_onceandpython_activation_snapshot_preserves_internal_directory_aliasincrates/cli/tests/coverage/shared/plugins_lifecycle_tests.rs.Validation:
cargo clippy -p nemo-relay-cli --all-targets -- -D warningscargo fmt --all -- --checkRelated Issues