Created cardinal Semiotic class for Kannada TN - #448
Open
richa-2002 wants to merge 46 commits into
Open
Conversation
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
richa-2002
marked this pull request as ready for review
July 7, 2026 10:49
Signed-off-by: richa-2002 <richa@nvidia.com>
…iles Signed-off-by: richa-2002 <richa@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
richa-2002
force-pushed
the
feat-kn-cardinal
branch
from
July 23, 2026 12:22
9149d5a to
53b3447
Compare
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
This PR is stale because it has been open for 14 days with no activity. Remove stale label or comment or update or this will be closed in 7 days. |
mgrafu
reviewed
Sep 1, 2026
mgrafu
reviewed
Sep 1, 2026
Signed-off-by: richa-2002 <richa@nvidia.com>
for more information, see https://pre-commit.ci
Author
|
Thank you for the review, @mgrafu. I have addressed all the changes you suggested. Additionally, I removed the unnecessary weights from cardinal.py file from tagger module. Testing |
Signed-off-by: richa-2002 <richa@nvidia.com>
mgrafu
reviewed
Sep 8, 2026
mgrafu
reviewed
Sep 8, 2026
mgrafu
reviewed
Sep 8, 2026
mgrafu
reviewed
Sep 8, 2026
Signed-off-by: richa-2002 <richa@nvidia.com>
for more information, see https://pre-commit.ci
Signed-off-by: richa-2002 <richa@nvidia.com>
Signed-off-by: richa-2002 <richa@nvidia.com>
for more information, see https://pre-commit.ci
Author
|
Thank you for the review, @mgrafu. I have addressed all the changes you suggested. Testing
|
mgrafu
reviewed
Sep 9, 2026
mgrafu
reviewed
Sep 9, 2026
mgrafu
reviewed
Sep 9, 2026
mgrafu
reviewed
Sep 9, 2026
| import pynini | ||
| from pynini import Far | ||
| from pynini.export import export | ||
| from pynini.lib import byte, pynutil, utf8 |
Collaborator
There was a problem hiding this comment.
please clean up any unused imports in all scripts (byte is not used here)
Collaborator
There was a problem hiding this comment.
please check other imports / files
mgrafu
reviewed
Sep 9, 2026
Signed-off-by: richa-2002 <richa@nvidia.com>
Author
|
Thank you for the review, @mgrafu. I have addressed all the changes you suggested. Testing Pytest: All test cases passed — Cardinal, Word, and Punctuation. |
mgrafu
reviewed
Sep 10, 2026
| ನಾನು 20' ಮತ್ತು 14/ ಅವರು ನಾನು 16.~ನಾನು ಇಪ್ಪತ್ತು ' ಮತ್ತು ಹದಿನಾಲ್ಕು / ಅವರು ನಾನು ಹದಿನಾರು . | ||
| ಅವನು ಮತ್ತು ನಾನು ಮತ್ತು ಮುಲ್ಲರ್ನ ಮತ್ತು ದೆತ್ರ್~ಅವನು ಮತ್ತು ನಾನು ಮತ್ತು ಮುಲ್ಲರ್ನ ಮತ್ತು ದೆತ್ರ್ | ||
| 'ಪರೀಕ್ಷೆ'.~'ಪರೀಕ್ಷೆ'. | ||
| ಇದು (12 ಪ್ರಭೇದಗಳು) ಮತ್ತು...~ಇದು ( ಹನ್ನೆರಡು ಪ್ರಭೇದಗಳು) ಮತ್ತು... |
Collaborator
There was a problem hiding this comment.
why are spaces added for some parens but not others?
mgrafu
reviewed
Sep 10, 2026
| 1! ಹಲೋ~ಒಂದು! ಹಲೋ | ||
| 1 ,~ಒಂದು , | ||
| (1) ಹಲೋ~(ಒಂದು) ಹಲೋ | ||
| 1! ಹಲೋ~ಒಂದು! ಹಲೋ |
Collaborator
There was a problem hiding this comment.
why is this test repeated?
Collaborator
There was a problem hiding this comment.
please remove repeated test cases in all data files
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Add a one line overview of what this PR aims to accomplish.
Before your PR is "Ready for review"
Pre checks:
git commit -sto sign.pytestor (if your machine does not have GPU)pytest --cpufrom the root folder (given you marked your test cases accordingly@pytest.mark.run_only_on('CPU')).bash tools/text_processing_deployment/export_grammars.sh --MODE=test ...pytestand Sparrowhawk here.__init__.pyfor every folder and subfolder, includingdatafolder which has .TSV files?Copyright (c) 2026, NVIDIA CORPORATION & AFFILIATES. All rights reserved.to all newly added Python files?Copyright 2015 and onwards Google, Inc.. See an example here.try import: ... except: ...) if not already done.PR Type:
If you haven't finished some of the above items you can still open "Draft" PR.