Conversation
Drop the hand-rolled containsInt and use slices.Contains from the standard library at its three call sites. Signed-off-by: woodsonl <65194841+woodsonl@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drops the hand-rolled
containsInthelper ineap-nooband usesslices.Containsfrom the standard library at its three call sites. Nobehavior change.
Release intent
Changelog title
n/a
Changelog body
n/a
Bumps
Scope
Included: the helper removal and the three call-site changes.
eap-noobis an internal library, so no service binary's behavior changes.Excluded: nothing else.
Validation
go build ./...andgo test ./...inservices/eap-noobRisk
None. Pure standard-library substitution.
Checklist
git commit -s), certifying the Developer Certificate of Origin.services/versions.jsonis written by automation — do not edit it by hand.