Conversation
The release-intent parser expects the keys in services/versions.json, where the suite version is "services". The skill still told agents to write "product", so both of its example blocks failed validate_pr.py. Signed-off-by: Som Tripathi <somtri@iastate.edu>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
.cursor/skills/pair-github-pr/SKILL.mdstill uses the pre-#87productbump key. The parser expects the keys inservices/versions.json, where the suite version isservices. The PR template andservices/VERSIONING.mdalready useservices.Both example blocks in the skill fail the check on
develop:This renames the key in the two examples, the key-list note, the severity rule, and one example heading. The severity rule also drops "product" from "UI-only product notes". No other wording changes.
Release intent
Changelog title
n/a
Changelog body
n/a
Bumps
Scope
Included:
.cursor/skills/pair-github-pr/SKILL.mdonly.Excluded:
services/nvpair-cluster-manager/spec.mdandservices/nvpair-job-scheduler/spec.mdstill mention aproductbump. They are service specs, so I did not touch them here.Validation
python scripts/release-intent/validate_pr.py --description-file <example> --skip-owned-files-checkon each example block: exit 1 with the error above before this change, exit 0 after it.node scripts/spdx-headers.mjs: 1024 checked, 0 missing.git diff --check: clean.Risk
Documentation only. No code, build, or version file changes.
Checklist
git commit -s), certifying the Developer Certificate of Origin.validate_pr.pyruns on both examples.services/versions.jsonis written by automation — do not edit it by hand.