Skip to content

Use the services key in the pair-github-pr release-intent examples - #120

Open
somtri wants to merge 1 commit into
NVIDIA:developfrom
somtri:docs/release-intent-skill-services-key
Open

somtri wants to merge 1 commit into
NVIDIA:developfrom
somtri:docs/release-intent-skill-services-key

Conversation

@somtri

@somtri somtri commented Sep 23, 2026

Copy link
Copy Markdown

Description

.cursor/skills/pair-github-pr/SKILL.md still uses the pre-#87 product bump key. The parser expects the keys in services/versions.json, where the suite version is services. The PR template and services/VERSIONING.md already use services.

Both example blocks in the skill fail the check on develop:

Bump keys must match services/versions.json exactly (missing keys: services; unknown keys: product)

This renames the key in the two examples, the key-list note, the severity rule, and one example heading. The severity rule also drops "product" from "UI-only product notes". No other wording changes.

Release intent

Changelog title

n/a

Changelog body

n/a

Bumps

  • services: none
  • nvpair-cluster-manager: none
  • nvpair-engine-manager: none
  • nvpair-errors: none
  • nvpair-job-scheduler: none
  • nvpair-manual-nodes: none
  • nvpair-node-info: none
  • nvpair-node-scanner: none
  • nvpair-node-settings: none
  • nvpair-proxy: none
  • nvpair-tui: none
  • nvpair-ui-broker: none
  • nvpair-workload-manager: none

Scope

Included: .cursor/skills/pair-github-pr/SKILL.md only.

Excluded:

  • The skill's description order ("Summary → Test plan") differs from the current template. I left it alone because the skill puts the intent fence first on purpose, and the template does not.
  • services/nvpair-cluster-manager/spec.md and services/nvpair-job-scheduler/spec.md still mention a product bump. They are service specs, so I did not touch them here.

Validation

  • python scripts/release-intent/validate_pr.py --description-file <example> --skip-owned-files-check on each example block: exit 1 with the error above before this change, exit 0 after it.
  • The same command on this description: exit 0.
  • node scripts/spdx-headers.mjs: 1024 checked, 0 missing.
  • git diff --check: clean.

Risk

Documentation only. No code, build, or version file changes.

Checklist

  • I have read the Contributing Guidelines.
  • Every commit is signed off (git commit -s), certifying the Developer Certificate of Origin.
  • New or existing tests cover the change. Not applicable: documentation only. The Validation section lists the validate_pr.py runs on both examples.
  • Relevant documentation is updated.
  • I checked the diff, changed filenames, and commit messages for credentials, private data, internal URLs, internal issue identifiers, and generated artifacts.
  • I recorded the validation commands and results above.
  • I declared version bumps in the release-intent block above. services/versions.json is written by automation — do not edit it by hand.

The release-intent parser expects the keys in services/versions.json,
where the suite version is "services". The skill still told agents to
write "product", so both of its example blocks failed validate_pr.py.

Signed-off-by: Som Tripathi <somtri@iastate.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant