Persist manual nodes in the broker - #60
sylvesterkaczmarek wants to merge 1 commit into
Conversation
Signed-off-by: Sylvester Kaczmarek <16242628+sylvesterkaczmarek@users.noreply.github.com>
|
This makes sense. Moving MR against develop branch. |
|
I'm working on a massive overhaul to the TUI that we will want to bring in before we make other TUI changes. As soon as that comes in I'd love to get this updated and then will verify it against the new codebase. |
|
Thanks Noah, and thanks Sherief for moving this onto develop. Makes sense. I’ll rebase and adapt the persistence change once the TUI overhaul lands so it fits the new structure cleanly. |
|
@sylvesterkaczmarek can you have a look at the major overhaul I made to the TUI - #117. Would love to get eyes there, I think we will still need this fix. |
|
I reviewed the manual-node/persistence path in #117. The new node-first TUI is compatible with this PR and does not replace it: the manual-nodes worker is still in-memory only, the broker still documents restart loss, and the desktop still owns replay. The TUI keeps the existing node/add, node/remove and nodes/list contract and correctly preserves the manual alias separately from the stable node key. So I agree this fix is still needed. I’ll adapt/rebase #60 once #117 lands rather than racing the overhaul. |
Closes #58
Description
Move manual-node durability into
nvpair-ui-brokerso headless TUI/service nodes keep manual peers across broker and worker restarts. Successful add/remove operations update the existingconfigs/manual-nodes.json, and a restarted manual-nodes worker is repopulated automatically.Scope
nvpair-ui-brokerfrom 0.40.2 to 0.40.3Validation
make check- passed, including 208 desktop unit testsgo test ./...inservices/nvpair-ui-broker- passed-count=3- passednpm run dead-code:check- passedmake test-servicesreaches an existinglmstudio-proxyE2E port-selection failure; the same failing test reproduces on pristinemainRisk
The JSON-RPC surface is unchanged. Existing desktop
manual-nodes.jsonentries remain readable because the broker takes ownership of the same file and schema.Checklist
services/versions.jsonand described the user-visible change above.