Conversation
Signed-off-by: Som Tripathi <somtri@iastate.edu>
|
Heads up — This PR edits files in those directories, so it will need updating before it can Apologies for the churn, and thanks for the contribution. Happy to help work out |
…appdata-isolation Signed-off-by: Som Tripathi <somtri@iastate.edu> # Conflicts: # services/lmstudio-proxy/e2e_test.go # services/tests/main_test.go
Signed-off-by: Som Tripathi <somtri@iastate.edu>
|
I merged |
Description
Fixes #48.
Some Go tests inherited the developer's PAIR app-data directory. A saved LM Studio port file could affect a later run, and a test could overwrite the developer's saved port.
developreplacedservices/lmstudio-proxyandservices/ollama-proxywithservices/nvpair-proxy, so this branch now mergesdevelopand ports the change to the unified proxy:services/testssets a private configuration root for every child binary it starts. A new test starts a realnvpair-proxy, enables the LM Studio facade, sendslmstudio:set-port, and checks that the port file is written below that root.nvpair-proxyend-to-end failover test redirects the configuration root before it starts its child process.Both set the variables after
go build. On Linux and macOS, Go derives its module and build caches fromHOME, so redirecting it earlier would build into the test directory.Release intent
Changelog title
n/a
Changelog body
n/a
Bumps
Scope
Included:
services/tests/main_test.goandservices/nvpair-proxy/e2e_test.go.Excluded:
nvpair-ui-brokertest file.services/nvpair-ui-broker/testmain_test.goondevelopalready isolates that package, and a secondTestMainwould not compile. The merge removes it.Validation
go test . -run TestE2EFailoverOverRealBinary -count=2inservices/nvpair-proxypassed on Windows 11 with Go 1.26.5.go test . -run TestLMStudioFacadeChildPersistsUnderPrivateBase -count=2inservices/testspassed on the same machine.go test . -count=1passed inservices/nvpair-proxyand inservices/tests. The only skips were the opt-in CORS tests andTestBrokerShutsDownOnSignal.%LOCALAPPDATA%\Nvidia Corporation\Personal AI Routerdirectory did not exist before these runs and did not exist after them.nvpair-proxypackage passed. With the variable loop removed, the new test fails with "outside test config base".node scripts/spdx-headers.mjs,git diff --check, andscripts/release-intent/validate_pr.pyon this description passed.Risk
This change affects test setup only. Compiled binaries and normal PAIR configuration resolution are unchanged.
Checklist
git commit -s), certifying the Developer Certificate of Origin.services/versions.jsonis written by automation — do not edit it by hand.