[CI] Pin JAX image to 2026-07-21#3250
Conversation
Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
|
The important job to watch here is the "All" job. The JAX job has a pre-existing failure that has surfaced again |
Greptile SummaryThis PR replaces the rolling
Confidence Score: 5/5Safe to merge — the change is a targeted two-line update that locks the JAX image to a known-good date tag and directly addresses the rolling-tag breakage in CI. Both usages of the JAX image tag are updated consistently (the job-level container and the docker run call), and the replaced rolling tag was the confirmed cause of CI failures. No logic, test, or application code is touched. No files require special attention. The only suggestion is a follow-up hardening step (digest pinning) noted by the PR author themselves. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[build.yml workflow] --> B[core job]
A --> C[pytorch job]
A --> D[jax job]
A --> E[all job]
B --> B1["nvcr.io/nvidia/cuda:12.1.0-devel-ubuntu22.04\n(unchanged)"]
C --> C1["nvcr.io/nvidia/cuda:12.8.0-devel-ubuntu22.04\n(unchanged)"]
D --> D1["ghcr.io/nvidia/jax:jax-2026-07-21\n(pinned from :jax rolling tag)"]
E --> E1["ghcr.io/nvidia/jax:jax-2026-07-21\n(pinned from :jax rolling tag)"]
style D1 fill:#90EE90
style E1 fill:#90EE90
Reviews (1): Last reviewed commit: "[CI] Pin JAX image to 2026-07-21" | Re-trigger Greptile |
| runs-on: ubuntu-latest | ||
| container: | ||
| image: ghcr.io/nvidia/jax:jax | ||
| image: ghcr.io/nvidia/jax:jax-2026-07-21 |
There was a problem hiding this comment.
Date tags are mutable — an image registry owner can push a new image to
jax-2026-07-21 at any time. Pinning to an immutable digest (e.g. ghcr.io/nvidia/jax@sha256:<digest>) would guarantee bit-for-bit reproducibility. Since the PR description already notes this is a temporary measure, this is just a pointer for the follow-up.
| image: ghcr.io/nvidia/jax:jax-2026-07-21 | |
| image: ghcr.io/nvidia/jax@sha256:<digest-of-jax-2026-07-21> # pin by digest for immutability |
Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Description
CI tests on GH runners are failing because they pull the latest, rolling
ghcr.io/nvidia/jax:jaximage tag. This poses a couple of problems:This locks the image to
ghcr.io/nvidia/jax:jax-2026-07-21. The tradeoff here is that the image will need to be periodically updated. IMO this should be pinned further, but locking it to the 07/21 image should get CI unblocked.Fixes # (issue)
Type of change
Changes
Please list the changes introduced in this PR:
ghcr.io/nvidia/jax:jax-2026-07-21Checklist: