Add CUDA wheels as build-time requirements for build isolation#3253
Draft
fheinecke wants to merge 2 commits into
Draft
Add CUDA wheels as build-time requirements for build isolation#3253fheinecke wants to merge 2 commits into
fheinecke wants to merge 2 commits into
Conversation
Signed-off-by: Fred Heinecke <fheinecke@nvidia.com>
Collaborator
Author
|
/te-ci |
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One of the issues blocking wheel build isolation is that CUDA build-time dependencies (e.g. nvcc) are not available today. These cannot easily be statically defined in pyproject.toml, because the exact dependencies required depend on whether the wheel is being built for CUDA 12 or CUDA 13.
This PR adds a PEP 517/660 compliant
build_system.pythat defines these requirements based on specific build-time flag, env var, or system dependencies. As with today, this logic is completely ignored when--no-build-isolationis set, so it should have no impact on existing release processes. This does not completely enable build isolation, but fixes most of the remaining blockers.I have intentionally listed this as "not for external use" in the documentation. I'll update this and the install docs once build isolation is completely supported.
Depends on #3251
Type of change
Changes
Please list the changes introduced in this PR:
Checklist: