Conversation
Signed-off-by: Vivek Goel <vigoel@nvidia.com>
f05130f to
ef0327b
Compare
|
@pengcuo Please help review this PR. Thanks. |
|
Thanks for the PR, Vivek. The CFG-parallel idea is good and the core logic is correct: both ranks run the same collectives in the same order, Two things will take the 2-rank server down in real use, so I'd like them fixed before merge:
Smaller items, fine as follow-ups:
I reproduced item 1 with a 2-process gloo simulation; happy to share the script. |
|
@pengcuo Thanks for detailed review comments. I will address these and push another patch soon. |
Summary
Adds explicit two-rank CFG-parallel support to the RoboLab action-policy server without enabling FSDP or context parallelism.
Changes
--cfg-parallelCLI option.dp_shard=1,cfgp=1,cp=1--cfg-parallel:dp_shard=1,dp_replicate=2,cfgp=2,cp=1OmniInferenceguardrails, avoiding unnecessary Guardrail1 downloads and model allocation.Runtime behavior
Rank 0 receives the WebSocket request and broadcasts
{obs, seed}to rank 1. Both ranks construct the same transformed batch and participate in CFG-parallel generation:Both GPUs hold a complete copy of the policy model. Model weights are not FSDP-sharded.
Usage
Limitations
Validation