docs: add pull request guidelines to CONTRIBUTING.md - #967
Open
dims wants to merge 1 commit into
Open
Conversation
Add a new section covering how to structure PRs well: - group cross-distro fixes for the same root cause into one PR - open an issue before sending bulk fixes - avoid opening many PRs in a single session to protect shared CI - check for existing open PRs on the same file to prevent conflicts - separate cosmetic changes from correctness fixes - write tests that execute code, not just grep for old patterns - link every PR to an issue Signed-off-by: Davanum Srinivas <dsrinivas@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Motivation
The repo received a large batch of AI-generated PRs on a single day (49 open PRs, all same date, many targeting the same file and same root cause). Clear written guidance helps both AI agents and human contributors structure contributions in a way that is reviewable and CI-friendly.
Test plan