Skip to content

Report the selected deployment rebuild manifest in inspection - #196

Open
0z5a wants to merge 7 commits into
NVIDIA:mainfrom
0z5a:fix-inspect-selected-rebuild
Open

0z5a wants to merge 7 commits into
NVIDIA:mainfrom
0z5a:fix-inspect-selected-rebuild

Conversation

@0z5a

@0z5a 0z5a commented Nov 4, 2026 •

Copy link
Copy Markdown

Summary

Payload-format flare inspect --json omits rebuild manifests recorded in signed deployments. Populate the verified inspection descriptor from the selected authenticated deployment. Unverified inspection now shows each decoded deployment's manifest and, when a deployment is selected, its manifest at the top level; it remains explicitly labeled unverified and the top-level value is null for an unselected multi-deployment catalog.

Serving and package validation remain unchanged; packages without a manifest continue to report null.

Fixes #195 and removes the completed item from docs/TODO.txt.

Validation

  • A real signed two-deployment fixture covers directory and packed packages, verified and unverified inspection, full and rank-selected views, absent manifests, and an unselected catalog. The verified selection test fails before the fix and passes afterward.
  • All 11 payload-package protection tests and the legacy no-manifest inspection test passed using cargo test --offline --features runtime-package --lib.
  • Inspection exercised package metadata without a GPU; no native model serving was run.

0z5a added 2 commits November 4, 2026 08:07
Read the authenticated selected deployment manifest for payload inspection.
Signed multi-deployment package tests pass for directory and packed files,
full and rank-selected views, and absent metadata. The legacy no-manifest
inspection test also passes. No GPU serving was exercised.

Design-Signed-Off-By: GPT-6 (OpenAI GPT-6); design-review=a38f
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Show each decoded deployment manifest and the selected manifest, retaining
explicit unverified labeling and leaving the top-level value null when the
catalog has no selected deployment. Signed directory and packed fixture
checks pass; no GPU serving was exercised.

Design-Signed-Off-By: GPT-6 (OpenAI GPT-6); design-review=a38f
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
@original-el8 original-el8 added area:packaging Package assembly, verification, distribution, inspection, and loading. bug Something isn't working priority:P2 Normal bug priority: workflow failure or diagnosis with narrower impact or an available workaround. triage:review Proposed change needs code review; this does not imply merge readiness. labels Nov 5, 2026
@original-el8

Copy link
Copy Markdown
Collaborator

@0z5a GitHub reports that this PR has merge conflicts with main. A local git merge-tree check also confirms conflicts for PR head 94e1d5c1d247 against main at c65024dba32b (2026-11-05).

Conflicting files:

  • docs/TODO.txt

Please update the branch against main (rebase or merge), resolve these conflicts, and rerun the affected checks.

Keep main's new proposal/verification graph entry in docs/TODO.txt and drop the
rebuild-inspection entry this branch completes. Helios merged without textual
conflicts; the merged tree differs from main only by this branch's inspection
changes and that TODO removal.

Validation on Linux aarch64:
- cargo test --locked --manifest-path helios/Cargo.toml --features
  runtime-package --lib: 865 passed, 0 failed, 20 ignored, including
  payload_inspection_reports_selected_deployment_rebuild_metadata.
- cargo check --locked --manifest-path flare/Cargo.toml, which links Helios with
  runtime-package and server: succeeded.
No GPU serving was exercised; x86_64 and Windows builds were not run.

Design-Signed-Off-By: DeepSeek Harness (deepseek-flash); design-review=a38f
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
@original-el8

Copy link
Copy Markdown
Collaborator

@0z5a GitHub reports merge conflicts with main; local git merge-tree confirms them for PR head ba5375cb9eda against main at 91cfb3695f10. Conflicting files:

  • docs/TODO.txt

Please reconcile these files with main and rerun the checks affected by the resolution.

0z5a and others added 2 commits November 8, 2026 23:57
NVIDIA main added two docs/TODO.txt entries (explicit A16 activation
arithmetic in SM103 MXFP8 projections, and a file-descriptor preflight
before TP package assembly) directly after the rebuild-inspection entry
that this branch removes, so the two sides conflicted in that file.

The resolution keeps both entries from main and drops the
rebuild-inspection entry, which this branch completes. No other file
conflicted; the merged tree differs from main only by this branch's
inspection changes in helios/src/runtime_package/ and that TODO removal.

Validation on Linux x86_64 (rustc 1.99 stable, protoc 36.2), no GPU:
- cargo test --locked --manifest-path helios/Cargo.toml --features
  runtime-package --lib: 887 passed, 0 failed, 21 ignored, including
  payload_inspection_reports_selected_deployment_rebuild_metadata.
- cargo check --locked --manifest-path flare/Cargo.toml: succeeded.
No GPU serving was exercised; aarch64 and Windows builds were not run.

Design-Signed-Off-By: 0z5a; design-review=3ad6
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Resolve the core reorganization: the rebuild inspection now lives in
runtime_core/protection.rs, and the new test uses the renamed
runtime_core, core::conversion, VerifiedCore, two_deployment_core and
the "core" metadata key. The TODO entry stays removed.
Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@0z5a

0z5a commented Nov 10, 2026

Copy link
Copy Markdown
Author

@original-el8 Merged main in 24d2c4b. docs/TODO.txt: the rebuild-metadata entry stays removed, since this PR implements it. The merge also had to follow the core reorganization: the rebuild inspection now lives in runtime_core/protection.rs, and the new test uses runtime_core, core::conversion, VerifiedCore, two_deployment_core and the "core" metadata key. I haven't rerun cargo on the merged head yet, so please rely on CI for the build and tests.

0z5a added 2 commits November 11, 2026 22:13
…into fix-inspect-selected-rebuild

Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
…into fix-inspect-selected-rebuild

Signed-off-by: 0z5a <dezhen.lu@student.uni-tuebingen.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area:packaging Package assembly, verification, distribution, inspection, and loading. bug Something isn't working priority:P2 Normal bug priority: workflow failure or diagnosis with narrower impact or an available workaround. triage:review Proposed change needs code review; this does not imply merge readiness.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Payload inspection omits the selected deployment rebuild manifest

2 participants