Repository navigation
Fix Windows ARM64 builds of frame-completion wait code - #315
Merged
Merged
Conversation
Windows ARM64 CLI and WinUI builds fail because the architecture-only guard for Helios's frame-completion wait module compiles libc::getauxval and libc::AT_HWCAP2, which are Linux-only. The optimization relies on Linux hardware-capability discovery. Require both Linux and ARM64 for the host_wait module, wake-word initialization, park implementation, and timeout constant. Other targets use the existing polling path, with CUDA event queries continuing to determine frame completion. This restores native Windows ARM64 compilation. Linux ARM64 retains the same wait implementation. Validation on native Windows ARM64 with Rust 1.100.0: - scripts/dev_windows.ps1 -Action Build passed. - scripts/build_winui.ps1 -Platform ARM64 -Configuration Release -SingleFile passed, including the Rust bridge and single-file launcher. - scripts/dev_windows.ps1 -Action Smoke passed version, top-level help, download help, and JSON model-list checks. Linux builds and wait execution, GUI launch, and model inference were not tested. Design-Signed-Off-By: Codex (GPT-6); design-review=ed22
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Windows ARM64 CLI and WinUI builds fail because the architecture-only guard for Helios's frame-completion wait module compiles libc::getauxval and libc::AT_HWCAP2, which are Linux-only. The optimization relies on Linux hardware-capability discovery.
Require both Linux and ARM64 for the host_wait module, wake-word initialization, park implementation, and timeout constant. Other targets use the existing polling path, with CUDA event queries continuing to determine frame completion.
This restores native Windows ARM64 compilation. Linux ARM64 retains the same wait implementation.
Validation on native Windows ARM64 with Rust 1.100.0:
Linux builds and wait execution, GUI launch, and model inference were not tested.