Repository navigation
Conversation
Firefox 160 (ubuntu-24.04 runner image 20261103.629) fails the check
"fullscreen button and Alt+Enter" with {"on":false,"w":960}. Reproduced
in a container with Firefox 159.0 and 160.0 from ftp.mozilla.org under
xvfb-run and puppeteer-core 25.13.0 (WebDriver BiDi): the button's click
carries user activation (navigator.userActivation.isActive is true) and
calls requestFullscreen(), but on Firefox 160 on a bare Xvfb the promise
never settles and neither fullscreenchange nor fullscreenerror fires,
even after 6 s. Firefox 159 completes the same request on the same
display. With a window manager (Openbox) running on the display, both
versions enter fullscreen; headless Firefox 160 does too. So Firefox 160
on X11 waits for the window manager to make the window fullscreen, and
xvfb-run starts none. The page's fullscreen button is correct: a real
desktop always has a window manager.
The browser engine job installs openbox and the Firefox step starts it
inside xvfb-run before the suites. Chrome's steps are unchanged.
|
Preview of 52e3dc7 (candidates demos): https://micro-engine-mztjy34r1-nastmzs-projects.vercel.app |
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
On ubuntu-24.04 runner images with Firefox 160 (image 20261103.629), the browser engine check
fullscreen button and Alt+Enterfails with{"on":false,"w":960,"canvas":960}. This blocks CI result whenever the browser jobs run. Firefox 159 passes the same check.Cause
I reproduced it in a container (Firefox 159.0 and 160.0 from ftp.mozilla.org,
xvfb-run, puppeteer-core 25.13.0 over WebDriver BiDi):requestFullscreen()never settles (nofullscreenchange, nofullscreenerror, even after 6 s)The click carries user activation (
navigator.userActivation.isActiveis true). On X11, Firefox 160 waits for a window manager to make the window fullscreen, andxvfb-runstarts none. The page's fullscreen button is correct: a real desktop always has a window manager.Change
checks.yml: the browser engine job installsopenbox, and the Firefox step starts it insidexvfb-runbefore the suites. Chrome's steps are unchanged.docs/ci.md: says why Firefox runs under a window manager.Evidence
The browser engine jobs of this PR should show
Mozilla Firefox 160.0andPASS firefox <Game>: fullscreen button and Alt+Enter. Jobs that land on an older runner image will still show Firefox 159.🤖 Generated with Claude Code