Skip to content

Fix #5608 - define SWIG_PYTHON_SILENT_MEMLEAK for python package too - #5656

Merged
jmarrec merged 6 commits into
developfrom
5608-SWIG_PYTHON_SILENT_MEMLEAK
Sep 21, 2026
Merged

jmarrec merged 6 commits into
developfrom
5608-SWIG_PYTHON_SILENT_MEMLEAK

Conversation

@jmarrec

@jmarrec jmarrec commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator

Pull request overview

Pull Request Author

  • Model API Changes / Additions
  • Any new or modified fields have been implemented in the EnergyPlus ForwardTranslator (and ReverseTranslator as appropriate)
  • Model API methods are tested (in src/model/test)
  • EnergyPlus ForwardTranslator Tests (in src/energyplus/Test)
  • If a new object or method, added a test in NREL/OpenStudio-resources: Add Link
  • If needed, added VersionTranslation rules for the objects (src/osversion/VersionTranslator.cpp)
  • Verified that C# bindings built fine on Windows, partial classes used as needed, etc.
  • All new and existing tests passes
  • If methods have been deprecated, update rest of code to use the new methods

Labels:

  • If change to an IDD file, add the label IDDChange
  • If breaking existing API, add the label APIChange
  • If deemed ready, add label Pull Request - Ready for CI so that CI builds your PR

Review Checklist

This will not be exhaustively relevant to every PR.

  • Perform a Code Review on GitHub
  • Code Style, strip trailing whitespace, etc.
  • All related changes have been implemented: model changes, model tests, FT changes, FT tests, VersionTranslation, OS App
  • Labeling is ok
  • If defect, verify by running develop branch and reproducing defect, then running PR and reproducing fix
  • If feature, test running new feature, try creative ways to break it
  • CI status: all green or justified

@jmarrec jmarrec self-assigned this Sep 17, 2026
@jmarrec jmarrec added Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge. component - Python bindings labels Sep 17, 2026
@github-actions

github-actions Bot commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

🧪 Test Results Dashboard

Summary

Metric Value
Total Tests 0
Passed 0
Failed 0
Errors 0
Skipped 0
Success Rate 0.0%
Generated 2026-09-18 07:59:09 UTC

❌ Significant Test Failures

📊 Test Run Information

Run XML File Status
- No XML files found ❌ Missing

@jmarrec

jmarrec commented Sep 17, 2026

Copy link
Copy Markdown
Collaborator Author

Running a test workflow for TestPypi at https://github.com/NatLabRockies/OpenStudio/actions/runs/35243981411

… DLL

The Pypi package lacked the correct dllimport/dllexport declspecs for cross-DLL globals like Logger::instance() on Windows (cf aad08ee)
Reverts e7e1aa7

The "on:" already defines it. And currently in puython_build that if clause prevents a workflow dispatch event to run for eg
@jmarrec
jmarrec force-pushed the 5608-SWIG_PYTHON_SILENT_MEMLEAK branch from ba9efeb to d97cc4a Compare September 18, 2026 07:58
Most are straightforward github official actions, except these two where I reviewing the changelogs and deemed it safe enough to bump.

## configure-aws-credentials

 5.0.0: Changes boolean input handling. Now, unparseable values for boolean inputs throw an exception instead of defaulting to false. This should not be impacting unless you relied on invalid values for boolean inputs being coerced to false, as it was previously.

6.0.0: Update action to use node24 Note this requires GitHub action runner version v2.327.1 or later (#1632) (a7a2c11)

---

## marocchino/sticky-pull-request-comment v2 → v3 : upgrade node from 20 to 24 basically.
@jmarrec

jmarrec commented Sep 18, 2026

Copy link
Copy Markdown
Collaborator Author

@brianlball pip install -i https://test.pypi.org/simple/ openstudio==3.12.0a0

I tested it on my local ubuntu 24.04 machine, with 3.11.0 official and confirmed the memory leak message.

Then I tested this alpha prerelease and it's gone.

@brianlball

Copy link
Copy Markdown
Contributor

This works in the MCP testing, thank you!

@jmarrec
jmarrec merged commit 81f5ea6 into develop Sep 21, 2026
0 of 6 checks passed
@jmarrec
jmarrec deleted the 5608-SWIG_PYTHON_SILENT_MEMLEAK branch September 21, 2026 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component - Python bindings Pull Request - Ready for CI This pull request if finalized and is ready for continuous integration verification prior to merge.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PyPI openstudio==3.11.0 wheel still emits SWIG memleak warnings — #5422 fix not applied to wheel build

2 participants