Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
roach-php/core ^3.2(was~1.1.0),symfony/* ^7.0(was^6.0),php >=8.2(was>=8.0).services.php:HttpErrorMiddleware(RoachPHP\Downloader\Middleware\HttpErrorMiddleware, ctor:(LoggerInterface)) — drops responses with unallowed HTTP status, configured per spider via thehandleStatusoption;ProxyMiddleware(RoachPHP\Downloader\Middleware\ProxyMiddleware, ctor:(ContainerInterface, LoggerInterface)) — assigns proxies to requests, configured per spider via theproxy/loaderoptions.vimeo/psalm,psalm/plugin-symfony,psalm/plugin-phpunit): psalm 4.x requiressymfony/console <=6, incompatible withsymfony ^7.0. The psalm step needs either psalm 5/6 upgrade or removal (kept out of scope of this PR).Compatibility
The bundle is a thin wrapper (
RoachPhpBundle::boot()→Roach::useContainer()). Verified against roach-php/core v3.2.1: constructor signatures of all services previously registered inservices.php(Engine, Processor, RequestDeduplicationMiddleware, ExecuteJavascriptMiddleware, CookieMiddleware, StatsCollectorExtension, Downloader, ItemPipeline, Client, Runner, ArrayRequestScheduler, SystemClock, extensions, built-in middlewares) are unchanged since 1.x.Roach::useContainer(),Roach::startSpider(),Roach::collectSpider()andOverridessignatures are unchanged.RunSpiderCommand(roach:run) works as before.Testing
composer updateresolves cleanly on PHP 8.4: roach-php/core 3.2.1, symfony/console 7.4.x, symfony/serializer 7.4.x, symfony/maker-bundle 1.68, monolog 3.12, nyholm/psr 1.8.composer install --dry-run— nothing to install (stable resolution).php -lclean on all changed files.Notes for maintainers
.github/workflows/build.ymlstill pins php 8.0/8.1 andsymfony_version: 6.0.*and runs psalm — it will need a follow-up matrix update (php >= 8.2, symfony 7.*) and either psalm 5+ or removal of the psalm step. Kept out of this PR to keep the diff minimal.jakeasmith/http_build_url(pulled by core 3.2.1) is abandoned — upstream core concern, not bundle's.