workflow: per-activity maxIterations override for the LLM turn loop - #71
Open
localrivet wants to merge 1 commit into
Open
workflow: per-activity maxIterations override for the LLM turn loop#71localrivet wants to merge 1 commit into
localrivet wants to merge 1 commit into
Conversation
The turn budget in run_llm_loop was a hard-coded 50. A write-enabled resolve activity doing search + gated write + log per row legitimately exceeds that on a hard chunk (observed live: 47 turns for one 6-row chunk on the Vivid order-intake workflow, run d7a921b2's predecessor failing at 'exceeded max iterations' after 3 of 8 chunks). Read params.maxIterations on the activity — the exact shape the graph loop node already accepts (graph.rs) — falling back to the existing 50. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Npaqwqvb9Cnvz8tDqMGnzy
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LLM turn loop in
run_llm_loopcaps at a hard-codedMAX_ITERATIONS: u32 = 50. A write-enabled resolve activity (search + gated write + log per row) legitimately exceeds that on a hard chunk — observed live on the Vivid order-intake workflow: one 6-row chunk consumed 47 turns, and the run died withactivity resolve-and-record exceeded max iterationsafter 3 of 8 chunks.This reads
params.maxIterationson the activity — the same param shape the graph loop node already accepts ingraph.rs— and falls back to the existing default of 50 when absent. One pathway, one param name, no behavior change for workflows that don't set it.🤖 Generated with Claude Code
https://claude.ai/code/session_01Npaqwqvb9Cnvz8tDqMGnzy