Experimental refactor channel interfaces and implementations - #416
Draft
jedrek0429 wants to merge 5 commits into
Draft
Experimental refactor channel interfaces and implementations#416jedrek0429 wants to merge 5 commits into
jedrek0429 wants to merge 5 commits into
Conversation
This includes: - Replace classes with interfaces and make classes internal - Reorganise file structure for channels - Create a ChannelFactory to replace the old `*Channel.CreateFromJson` methods - Introduce a `TextChannelBase` abstraction This change now crossess the core assembly boundary and produces 93 errors on build. It is experimental and is a proof of concept for the proposed huge refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce a new structure for channel capabilities by replacing classes with interfaces, and reorganizing the file structure. This refactor aims to enhance the modularity and maintainability of the channel system, and reduce the number of ghost methods that are certain to return 404 as shown by #351.
This branch is experimental and is a proof of concept for the proposed huge refactor