Skip to content

[NH5] Update build for nh5#128

Draft
StephenOman wants to merge 13 commits into
NetHack-5-upgradefrom
update-cmake-build-for-NH5
Draft

[NH5] Update build for nh5#128
StephenOman wants to merge 13 commits into
NetHack-5-upgradefrom
update-cmake-build-for-NH5

Conversation

@StephenOman

Copy link
Copy Markdown
Collaborator

Changes in this PR allow the C/C++ components to be built successfully (I hope).

Note: This PR contains a lot of changes so I'm happy to split it out to make it easier to review.

Changes:

  1. Updated cmake build process to include Lua capabilities (largely based on cmake support for NetHack 3.7 NetHack/NetHack#662)
  2. Remove obsolete lev_comp and dgn_comp targets
  3. Refactor rl_procs window interface to match updated NetHack 5 specification
  4. Update Python bindings including change to support the gendered names for monsters
  5. Scope & other minor changes for RNG functions to match new function locations
  6. Refactor NLE function declarations to match NH5 style (removal of macros such as NDECL, FDECL etc.)

@StephenOman

Copy link
Copy Markdown
Collaborator Author

Spoke too soon 🤬

@StephenOman
StephenOman marked this pull request as draft July 22, 2026 19:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant