fix(runtime): normalize optional tool schemas - #453
Open
Fxde42 wants to merge 1 commit into
Open
Conversation
Normalize object schemas at the final OpenAI Completions payload boundary because pi-ai passes omitted required fields through and Kimi intermittently rejects them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #452
Testing
BP_MOCK=1 npm test -w @brainpilot/runtime— 573 passednpm run typecheckBP_MOCK=1 npx vitest run packages/runtime/src/__tests__/tool-schema-compat.test.ts packages/runtime/src/__tests__/openai-tool-schema-compat.test.ts— 7 passedAI assistance
This PR was implemented and self-reviewed with AI assistance.