Repository navigation
ci: run UI tests, fix the 11 failing ones - #4
Merged
Merged
Conversation
The grid and each card applied .accessibilityIdentifier to a plain container, which SwiftUI stamps onto every child: the Edit Widgets button and each card's header icon reported the container's identifier, so UI tests found the wrong elements or none. Tests: resize via Contributions (Weekly rhythm became fixed-size in 7985b86) and reorder via Move Earlier, since synthesized drags never reach the grid's DragGesture.
The project row's identifier also landed on its collapse chevron, so a click meant for the row collapsed the project. Session bar meta labels now combine icon and text into one element. Tests: session identity moved from the window subtitle into the session bar (DetailColumn), which shows the branch without the flotilla/ prefix.
Identifiers on the window, diff pane, file sections and hunks were stamped onto every descendant, hiding the mode buttons, file comment buttons and hunk layouts from UI tests.
Deleting a session refuses to remove a folder git doesn't list as a worktree, so the bare fixture directory was never removed.
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+68
to
+108
| runs-on: xcode-27 | ||
| timeout-minutes: 45 | ||
|
|
||
| env: | ||
| SIGNING_OVERRIDE: CODE_SIGNING_ALLOWED=NO CODE_SIGNING_REQUIRED=NO DEVELOPMENT_TEAM= | ||
|
|
||
| steps: | ||
| - name: Checkout | ||
| uses: actions/checkout@v4 | ||
|
|
||
| - name: Install XcodeGen, tmux and displayplacer | ||
| run: brew install xcodegen tmux displayplacer | ||
|
|
||
| - name: Install Metal toolchain | ||
| run: xcodebuild -downloadComponent MetalToolchain | ||
|
|
||
| # The runner boots at 1024x768, narrower than the main window's | ||
| # minimum width, which leaves the toolbar and sidebars off-screen. | ||
| - name: Use a 1920x1080 display | ||
| run: | | ||
| id=$(displayplacer list | awk '/^Persistent screen id:/ {print $4; exit}') | ||
| displayplacer "id:$id res:1920x1080" | ||
| displayplacer list | grep -m1 '^Resolution:' | ||
|
|
||
| - name: Generate Xcode project | ||
| run: xcodegen generate | ||
|
|
||
| - name: Run UI tests | ||
| run: > | ||
| make test-ui SIGNING_OVERRIDE="$SIGNING_OVERRIDE" | ||
| TEST_FLAGS="-test-timeouts-enabled YES -maximum-test-execution-time-allowance 180" | ||
|
|
||
| - name: Upload test results | ||
| if: ${{ !cancelled() }} | ||
| uses: actions/upload-artifact@v4 | ||
| with: | ||
| name: ui-test-results | ||
| path: | | ||
| build/DerivedData/Logs/Test/*.xcresult | ||
| ~/Library/Logs/DiagnosticReports/Flotilla* | ||
| retention-days: 7 |
…shots VocabularyScreenshotUITests asserted nothing about the UI; it only fed docs/ui-vocabulary.md's figures. Drop it with its scheme and publisher scripts; the existing figures stay as hand-maintained docs. The agent-exit test attached two screenshots nothing checked, which failed it whenever the window was in a hidden Space.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds a parallel
ui-testsCI job and fixes the 11 UI tests that failed both locally and in CI.App fixes (accessibility): identifiers on plain containers were applied to every descendant, overriding the inner controls' own identifiers. Fixed with
.accessibilityElement(children: .contain)on the Home grid and cards, project rows, the Review window/pane/sections/hunks, and the Git sidebar. Icon+text labels now combine into one element. This also gives VoiceOver the inner controls' names back.Stale tests: the session identity moved from the window subtitle into the session bar, Weekly rhythm became fixed-size (7985b86), and branch names display without
flotilla/.Fixture: the Fix login bug worktree is now a real
git worktree, since deleting refuses to remove unregistered folders.Test-only workarounds: widget reordering goes through the context menu's Move Earlier (XCUITest drags never reach the grid's DragGesture), and the palette test types at app level (the SwiftUI field doesn't report focus on its element).
CI: the
ui-testsjob runs on its ownxcode-27runner, switches the display to 1920x1080 (it boots at 1024x768, narrower than the window's minimum width), and uploadsui-test-results.