Skip to content

Add resource pack constants#14

Merged
lineargraph merged 1 commit into
NotEnoughUpdates:masterfrom
AzureAaron:resource-pack
Jul 15, 2026
Merged

Add resource pack constants#14
lineargraph merged 1 commit into
NotEnoughUpdates:masterfrom
AzureAaron:resource-pack

Conversation

@AzureAaron

Copy link
Copy Markdown
Contributor

Adds support for the resource_pack.json file in the NEU repo, not sure if I did this right you may want to check. The file does not have anything in it so I don't think it could be tested well but if you have suggestions lmk.

I couldn't build the library either, my NEU repo is too new but assemble worked.

ItemModels itemModels;

@Value
public static class ItemModels {

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be an inner class or should be separate?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is just fine, we will have to look into versioning anyway.

@lineargraph

Copy link
Copy Markdown
Member

sorry, didnt mean to merge into your branch, ill undo this in a sec once i add your fork as a remote to this installation

@lineargraph

Copy link
Copy Markdown
Member

Error: Failed to CreateArtifact: Received non-retryable error: Failed request: (409) Conflict: an artifact with this name already exists on the workflow run

i declare this not an issue of this PR

@lineargraph lineargraph merged commit 569d931 into NotEnoughUpdates:master Jul 15, 2026
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants