Repository navigation
Close the last five v1 tickets (153-157) - #87
Merged
Merged
Conversation
- 153: unit tests pin money.ts, incl. the half-cent six-decimal rule - 154: debugFailure tests: silent without SESSCLONE_DEBUG, one line with it - 155: verify-collector refuses --day/--tz with no value (exit 2); parsing moves to an exported, tested parseArgs - 156: redact-transcript gets --help/-h (exit 0) and `<input>:<n>: not valid JSON`; logic moves to a tested redactJsonl - 157: install guide documents every verify-collector flag CONTRIBUTING no longer lists these as open good first issues. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01D7PEBxsvGv82SWK5amHyvu Signed-off-by: Claude <noreply@anthropic.com>
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Taha · project thread
Summary
apps/web/test/money.test.tspinsusd/count/compact, including the half-cent six-decimal rule. Expected strings came from running the code.packages/plugin/src/debug.test.mjs: silent withoutSESSCLONE_DEBUG, exactly one line with it, non-Errorthrows too.verify-collector.mjsrefuses--day/--tzwith no value, or followed by another flag (--day needs a value, exit 2). Parsing moved to an exportedparseArgsinpackages/plugin/src/verify.mjs, with tests.redact-transcript.mjstakes--help/-h(exit 0) and prints<input>:<n>: not valid JSON(exit 1). The logic moved toredactJsonlinpackages/shared/src/redact.ts, with tests.docs/install.mdhas a table of everyverify-collectorflag.CONTRIBUTING no longer lists these as open good first issues. The ticket graph has been rebuilt: all 167 done.
Linked issue or ticket
Tickets 153, 154, 155, 156, 157 under
.scratch/sessclone-v1/issues/.How it was tested
pnpm lintpnpm typecheckpnpm test(plugin + shared: 358 passed;money.test.tsrun separately since it needs no DB)pnpm test:db(no local Postgres here; no DB code changed)pnpm formatBy hand:
verify-collector --reconcile --dayand--reconcile --tz --day 2026-09-22both exit 2 naming the flag;redact-transcript --helpexits 0; a truncated line 2 printsbad.jsonl:2: not valid JSON.Checklist
🤖 Generated with Claude Code
https://claude.ai/code/session_01D7PEBxsvGv82SWK5amHyvu
Generated by Claude Code