Skip to content

Close the last five v1 tickets (153-157) - #87

Merged
NotTahaAli merged 1 commit into
mainfrom
claude/project-thread-61kxqq
Oct 12, 2026
Merged

NotTahaAli merged 1 commit into
mainfrom
claude/project-thread-61kxqq

Conversation

@NotTahaAli

Copy link
Copy Markdown
Owner

Requested by Taha · project thread

Summary

  • 153: apps/web/test/money.test.ts pins usd/count/compact, including the half-cent six-decimal rule. Expected strings came from running the code.
  • 154: packages/plugin/src/debug.test.mjs: silent without SESSCLONE_DEBUG, exactly one line with it, non-Error throws too.
  • 155: verify-collector.mjs refuses --day/--tz with no value, or followed by another flag (--day needs a value, exit 2). Parsing moved to an exported parseArgs in packages/plugin/src/verify.mjs, with tests.
  • 156: redact-transcript.mjs takes --help/-h (exit 0) and prints <input>:<n>: not valid JSON (exit 1). The logic moved to redactJsonl in packages/shared/src/redact.ts, with tests.
  • 157: docs/install.md has a table of every verify-collector flag.

CONTRIBUTING no longer lists these as open good first issues. The ticket graph has been rebuilt: all 167 done.

Linked issue or ticket

Tickets 153, 154, 155, 156, 157 under .scratch/sessclone-v1/issues/.

How it was tested

  • pnpm lint
  • pnpm typecheck
  • pnpm test (plugin + shared: 358 passed; money.test.ts run separately since it needs no DB)
  • pnpm test:db (no local Postgres here; no DB code changed)
  • pnpm format

By hand: verify-collector --reconcile --day and --reconcile --tz --day 2026-09-22 both exit 2 naming the flag; redact-transcript --help exits 0; a truncated line 2 prints bad.jsonl:2: not valid JSON.

Checklist

  • Every commit is signed off.
  • No new tables.
  • No new trust-boundary input.
  • No secrets, keys or real transcripts.

🤖 Generated with Claude Code

https://claude.ai/code/session_01D7PEBxsvGv82SWK5amHyvu


Generated by Claude Code

- 153: unit tests pin money.ts, incl. the half-cent six-decimal rule
- 154: debugFailure tests: silent without SESSCLONE_DEBUG, one line with it
- 155: verify-collector refuses --day/--tz with no value (exit 2);
  parsing moves to an exported, tested parseArgs
- 156: redact-transcript gets --help/-h (exit 0) and `<input>:<n>: not
  valid JSON`; logic moves to a tested redactJsonl
- 157: install guide documents every verify-collector flag

CONTRIBUTING no longer lists these as open good first issues.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01D7PEBxsvGv82SWK5amHyvu
Signed-off-by: Claude <noreply@anthropic.com>
@NotTahaAli NotTahaAli self-assigned this Oct 12, 2026
@coderabbitai

coderabbitai Bot commented Oct 12, 2026

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1cf7815e-3529-4271-873d-52b121edaa63

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@NotTahaAli
NotTahaAli merged commit adb9356 into main Oct 12, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant