Skip to content

fix string ids - #107

Open
xChipseq wants to merge 1 commit into
NuclearPowered:masterfrom
xChipseq:master
Open

fix string ids#107
xChipseq wants to merge 1 commit into
NuclearPowered:masterfrom
xChipseq:master

Conversation

@xChipseq

Copy link
Copy Markdown

this PR adds an additional patch for a GetString overload, fixing TextTranslatorTMP components set to a custom string name

@xChipseq

Copy link
Copy Markdown
Author

now that i look at it, it seems every GetString eventually uses this raw string one... the api ignores that fact and i don't know why. i'm guessing there's a reason for that so i'm not going to change anything else, this solution works lol

@XtraCube

Copy link
Copy Markdown
Contributor
image

not 100% but this may be the reason

@xChipseq

Copy link
Copy Markdown
Author

yeah very possible

@miniduikboot miniduikboot left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you give a small code sample that shows the problem though

@xChipseq

xChipseq commented Sep 4, 2026

Copy link
Copy Markdown
Author
// Example custom StringName, probably made useful by a custom provider of some sort 
var myStringName = CustomStringName.Create(); 
var textTranslator = someText.GetComponnect<TextTranslatorTMP>();

// This will not work, the text will say STRMISS
// TextTranslatorTMP uses the raw string method instead of the enum argument ones
textTranslator.TargetText = myStringName;
textTranslator.ResetText();

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants