ci: run on pull requests against any base branch - #32
Open
petlenz wants to merge 1 commit into
Open
Conversation
The pull_request trigger filtered on branches: [main], so a PR targeting a feature branch matched nothing. Work here lands through stacks -- #27..#31 all target a feature branch -- and not one of them has ever been built or tested by CI. The last run of any kind was main, three weeks ago. Dropping the filter runs the job for every pull request whatever its base. The push trigger keeps its main filter, so branch pushes add no load: a stacked branch is covered by its own PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
pull_requesttrigger filtered onbranches: [main], so a PR targeting a feature branch matched nothing.Work in this repo lands through stacks — #27, #28, #29, #30 and #31 all target a feature branch — and not one of them has ever been built or tested by CI. The most recent workflow run of any kind is
mainfrom 2026-07-28.push: branches: [main] pull_request: - branches: [main]Dropping the filter runs the job for every pull request whatever its base. The
pushtrigger keeps itsmainfilter, so branch pushes add no load — a stacked branch is covered by its own PR rather than by pushes to it.The job body needed no change:
NUMSIM_BUILD_TESTSandNUMSIM_BUILD_EXAMPLESare the real option names in CMakeLists.txt, andg++-14is installed and selected, which the<print>uses in the examples and plot targets require.Branched from
mainrather than folded into one of the stacked PRs, since the trigger is repo policy and not part of any feature. It has been merged into each of #27–#31 as well, becausepull_requestruns the workflow from the PR's merge ref — the fix has to be present on a head branch for that PR to get a run.