Skip to content

Make storage reads, metadata writes, and interrupts safe - #22

Merged
parashardhapola merged 1 commit into
masterfrom
pr/07-storage-robustness
Oct 23, 2026
Merged

parashardhapola merged 1 commit into
masterfrom
pr/07-storage-robustness

Conversation

@parashardhapola

Copy link
Copy Markdown
Member

Fixes silent wrong results and lost work in the storage layer.

Changes

  • cells.insert(name, series) aligns a labelled Series by cell ID instead of by position, which put annotations on the wrong cells.
  • A normalizer defined outside CyteArc is identified by a digest of its code and defaults, so an edited normalizer is not reused; revision 2 of the operations that record one.
  • A missing count, countsT, or artifact chunk raises instead of reading as zeros.
  • Stores with consolidated metadata no longer break writes.
  • Ctrl-C in Jupyter stops background readers and writers before control returns.
  • ds.artifacts.prune_incomplete(dry_run=True) finds and removes interrupted artifacts.
  • A fresh import is prepared by one process under an atomic claim, and min_features_per_cell applies only on the first writable open, which records it.
  • The Harmony 1.2.0 change is registered as a scoped revision; CyteArc no longer replaces other libraries' log handlers; listing, lineage, and argument checks are hardened.

Behaviour changes

  • A Series with a non-range index is aligned by label or raises.
  • Reopening a store never filters I again.
  • A store written by another tool that skips all-zero chunks no longer reads; the published CyteBase stores read normally.

@parashardhapola
parashardhapola force-pushed the pr/06-anndata-round-trip branch 2 times, most recently from 54db073 to 045ed66 Compare October 22, 2026 22:01
@parashardhapola
parashardhapola changed the base branch from pr/06-anndata-round-trip to master October 22, 2026 22:11
@parashardhapola
parashardhapola force-pushed the pr/07-storage-robustness branch from 0fa1981 to e7a6013 Compare October 22, 2026 22:11
Fixes silent wrong results and lost work in the storage layer.
@parashardhapola
parashardhapola force-pushed the pr/07-storage-robustness branch from e7a6013 to bc92efa Compare October 23, 2026 06:53
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@parashardhapola
parashardhapola merged commit 636cdd9 into master Oct 23, 2026
24 checks passed
@parashardhapola
parashardhapola deleted the pr/07-storage-robustness branch October 23, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants