Skip to content

[20.0][MIG] currency_rate_update: Migration to 20.0 - #238

Open
Mimbex wants to merge 158 commits into
OCA:20.0from
Mimbex:20.0-mig-currency_rate_update
Open

Mimbex wants to merge 158 commits into
OCA:20.0from
Mimbex:20.0-mig-currency_rate_update

Conversation

@Mimbex

@Mimbex Mimbex commented Sep 28, 2026

Copy link
Copy Markdown

This PR migrates currency_rate_update to Odoo 20.0.

  • Bumped manifest version to 20.0.1.0.0
  • Migrated security definitions to security/ir.access.csv
  • Fixed view definitions and removed deprecated tags
  • Updated unit tests for ECB provider
  • Passes pre-commit checks

Closes #236

@andyengit

Copy link
Copy Markdown

You must maintain the same commit history.

Check here: https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-20.0#how-to

@Mimbex
Mimbex force-pushed the 20.0-mig-currency_rate_update branch from 8ec7b48 to 5509322 Compare September 29, 2026 00:08
@Mimbex

Mimbex commented Sep 29, 2026

Copy link
Copy Markdown
Author

Done! Commits history from 19.0 has been imported via git format-patch --keep-subject --stdout origin/20.0..origin/19.0 -- currency_rate_update | git am -3 --keep and migration changes applied on top. Thank you @andyengit!

-->
<odoo noupdate="1">
<record model="ir.cron" id="ir_cron_currency_rates_update_every_day">
<record id="ir_cron_currency_rates_update_every_day" model="ir.cron">

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see a pre-commit commit "autofixes"; I'm not sure if the script did that or if you did.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are completely right. I ran pre-commit directly on the imported branch and split the autofixes into a dedicated [IMP] currency_rate_update: pre-commit auto fixes commit right before the [MIG] currency_rate_update: Migration to 20.0 commit, exactly as specified in the OCA migration workflow. Thank you for pointing that out!

jgrandguillaume and others added 23 commits September 28, 2026 21:21
(lp:c2c-addons/6.1  rev 1.1.3)
(lp:c2c-addons/6.1  rev 1.1.77)
(lp:c2c-addons/6.1  rev 1.2.14)
(lp:c2c-addons/6.1  rev 1.5.1)
(lp:c2c-addons/6.1  rev 1.5.15)
(lp:c2c-addons/6.1  rev 12)
(lp:c2c-addons/6.1  rev 13.1.1)
(lp:c2c-addons/6.1  rev 17)

[FIX] currency_rate_update - change on_changes in non private methods
(lp:c2c-addons/6.1  rev 18)
(lp:c2c-addons/6.1  rev 19.1.1)
(lp:c2c-addons/6.1  rev 22)
(lp:c2c-addons/6.1  rev 24.1.1)
(lp:c2c-addons/6.1  rev 24.1.3)
…report_webkit to 6.1 : API changes of 6.1, mainly the change of osv.memory now stored in DB, we should now have _columns, we can not rely anymore only on fields_view_get. Also shorten name files and wizard model names.

(lp:c2c-addons/6.1  rev 28)
(lp:c2c-addons/6.1  rev 49)

[FIX] spelling
(lp:c2c-addons/6.1  rev 77)
…e reactivated when the modules are migrated

[FIX] encoding should be coding
[IMP] hiding company_id field as always used within company form

[FIX]using logging instead of netscv

[FIX] imports

[FIX] use osv.Model

[DEL] remove unused wizard directory

[FIX] loading xml files

[FIX] parameter name

[IMP] copyright headers

[IMP] logging arguments
[IMP] clean spaces

[IMP] change license to AGPL
weblate and others added 26 commits September 28, 2026 21:21
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: currency-17.0/currency-17.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-17-0/currency-17-0-currency_rate_update/
Currently translated at 100.0% (72 of 72 strings)

Translation: currency-17.0/currency-17.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-17-0/currency-17-0-currency_rate_update/it/
Currently translated at 100.0% (72 of 72 strings)

Translation: currency-17.0/currency-17.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-17-0/currency-17-0-currency_rate_update/es_AR/
…ns in HTML module descriptions

WARNING devel py.warnings: /opt/odoo/custom/src/odoo/odoo/addons/base/models/ir_module.py:178:
DeprecationWarning: XML declarations in HTML module descriptions are deprecated since Odoo 17,
currency_rate_update can just have a UTF8 description with not need for a declaration.
The button to access the wizard is now directly visible from currency rate provider form view
Modernize the code to launch the wizard: replace ir.actions.server by ir.actions.act_window
Currently translated at 75.0% (54 of 72 strings)

Translation: currency-18.0/currency-18.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-18-0/currency-18-0-currency_rate_update/tr/
Currently translated at 37.5% (27 of 72 strings)

Translation: currency-18.0/currency-18.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-18-0/currency-18-0-currency_rate_update/lv/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: currency-18.0/currency-18.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-18-0/currency-18-0-currency_rate_update/
Currently translated at 94.5% (69 of 73 strings)

Translation: currency-18.0/currency-18.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-18-0/currency-18-0-currency_rate_update/lv/
Currently translated at 100.0% (73 of 73 strings)

Translation: currency-18.0/currency-18.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-18-0/currency-18-0-currency_rate_update/it/
Currently translated at 100.0% (73 of 73 strings)

Translation: currency-18.0/currency-18.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-18-0/currency-18-0-currency_rate_update/lv/
Currently translated at 35.6% (26 of 73 strings)

Translation: currency-18.0/currency-18.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-18-0/currency-18-0-currency_rate_update/ru/
Currently translated at 15.0% (11 of 73 strings)

Translation: currency-19.0/currency-19.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-19-0/currency-19-0-currency_rate_update/sl/
Currently translated at 15.0% (11 of 73 strings)

Translation: currency-19.0/currency-19.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-19-0/currency-19-0-currency_rate_update/sl/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: currency-19.0/currency-19.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-19-0/currency-19-0-currency_rate_update/
Currently translated at 100.0% (73 of 73 strings)

Translation: currency-19.0/currency-19.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-19-0/currency-19-0-currency_rate_update/it/
Currently translated at 100.0% (73 of 73 strings)

Translation: currency-19.0/currency-19.0-currency_rate_update
Translate-URL: https://translation.odoo-community.org/projects/currency-19-0/currency-19-0-currency_rate_update/sl/
@Mimbex
Mimbex force-pushed the 20.0-mig-currency_rate_update branch from 5509322 to 4c52d48 Compare September 29, 2026 02:26
@andyengit

Copy link
Copy Markdown

what do u think about this @pedrobaeza ?

@mileo mileo left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mod:currency_rate_update Module currency_rate_update series:20.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.