Repository navigation
[FIX] The duplicated name check compares root Directories with non-root Directories - #526
Conversation
7243818 to
a43982e
Compare
|
This PR has the |
pedrobaeza
left a comment
There was a problem hiding this comment.
The tests is not adding value, as it doesn't test a flow, but an ORM feature of adding a domain to a o2m field, so better to just not add it.
a43982e to
e62f63c
Compare
SirPyTech
left a comment
There was a problem hiding this comment.
The tests is not adding value, as it doesn't test a flow, but an ORM feature of adding a domain to a o2m field, so better to just not add it.
Thanks for the review!
Right we shouldn't test ORM features, the test made sense at the beginning of the PR when I was computing the value in a compute method.
I substituted the test with another one that checks the failing use case, please check if that's better now 🙏
|
Hey, thanks for contributing! Proceeding to merge this for you. |
|
Congratulations, your PR was merged at c433e7f. Thanks a lot for contributing to OCA. ❤️ |
Thanks 🙏 |
Steps:
Current:
WARNING devel odoo.http: A directory with the same name already exists.
Expected:
The directory can be created.
Additional Notes:
The root cause is that the storage's root directories are all the storage directories and the commit focuses on that.