Repository navigation
[19.0][FIX] dms: Set the appropriate default_parent_id - #527
Merged
Merged
Conversation
pedrobaeza
reviewed
Oct 19, 2026
pedrobaeza
approved these changes
Oct 19, 2026
adasatorres-tecnativa
approved these changes
Oct 19, 2026
Member
|
/ocabot merge patch |
Contributor
|
What a great day to merge this nice PR. Let's do it! |
Contributor
|
It looks like something changed on |
Contributor
|
Congratulations, your PR was merged at 1e68389. Thanks a lot for contributing to OCA. ❤️ |
Contributor
|
Thank you for working on this, I wanted to review it but got here too late 🫤 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Set the appropriate default_parent_id
Related to #522 (review)
Conclusions:
default_parent_idis not passed to the context of the_compute_parent_id()method._compute_parent_id()method that setrecord.parent_id = record.parent_idseemed to ensure that the appropriate default value was set in previous versions, but this is no longer the case.Please @pedrobaeza can you review it?
@Tecnativa