[19.0][MIG] edi_exchange_template_oca: Migration to 19.0 by sergijPf · Pull Request #250 · OCA/edi-framework

sergijPf · 2026-03-25T13:34:52Z

few changes done as per 19.0:

replace odoo.fields.first(), removed in core;
remove 'nocopy' param in safe_eval(), no more exists;
odoo_test_helper.FakeModelLoader replaced with _setup_env(), done similar way to edi_core_oca;
remove string/expand attributes for search view (edi_exchange_template_output_view_search), causing failure

etobella · 2026-03-25T13:46:23Z

/ocabot migration edi_exchange_template

etobella · 2026-03-25T13:46:37Z

/ocabot rebase

OCA-git-bot · 2026-03-25T13:46:47Z

@etobella The rebase process failed, because command git push --force DeineTuer-GmbH tmp-pr-250:19.0-mig-edi_exchange_template_oca failed with output:

remote: Repository not found.
fatal: repository 'https://github.com/DeineTuer-GmbH/edi-framework/' not found

etobella · 2026-03-27T10:10:56Z

/ocabot migration edi_exchange_template_oca

All the other main methods start with 'exchange_'. Make generate respect this convention.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: edi-framework-18.0/edi-framework-18.0-edi_exchange_template_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-18-0/edi-framework-18-0-edi_exchange_template_oca/

Currently translated at 100.0% (41 of 41 strings) Translation: edi-framework-18.0/edi-framework-18.0-edi_exchange_template_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-18-0/edi-framework-18-0-edi_exchange_template_oca/it/

Fix the behavior according to the feature ported from v14 and drop the deprecated lookup by code.

It slows down test suites by creating too many things when not needed.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: edi-framework-18.0/edi-framework-18.0-edi_exchange_template_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-18-0/edi-framework-18-0-edi_exchange_template_oca/

Currently translated at 100.0% (42 of 42 strings) Translation: edi-framework-18.0/edi-framework-18.0-edi_exchange_template_oca Translate-URL: https://translation.odoo-community.org/projects/edi-framework-18-0/edi-framework-18-0-edi_exchange_template_oca/it/

simahawk · 2026-06-09T09:58:39Z

+    def _prettify_xml(self, xml_string):
+        return etree.tostring(etree.fromstring(xml_string), pretty_print=True)
+
+    def _get_info_provider(self, exchange_record, work_ctx=None, usage=None, **kw):


@etobella this slipped out of our reviews when moving away from components: it's dead code w/o edi_component_oca.
In fact, this is a part that I wanted to remove anyway because the snippet already allow you to prepare data from where you want w/o needing to define a specific component.
The original idea was to be able to define default "info" components that could be reused.

@sergijPf pls get rid of it in a separate commit. Something like

[REM] edi_exchange_template_oca: get rid of dead code Meant to work with components only.

@simahawk removed as requested

simahawk · 2026-06-23T08:02:07Z

+from lxml import etree
+
+
+def xml_purge_nswrapper(xml_content):


@sergijPf may I ask you you to test one thing?
The nswrapper trick should be superflous today because to define namespaces you can use this approach

<t xmlns:cac="urn:oasis:names:specification:ubl:schema:xsd:CommonAggregateComponents-2"> <cac:DeliveryParty> [...] </cac:DeliveryParty> </t>

If this works, we can leave behind this trick.

SilvioC2C

The PR looks good overall, I'm afraid the new first_of function might crash. Can you please test it (possibly add an automated test)?

SilvioC2C · 2026-09-21T10:00:00Z

+
+    def _time_utils(self):
+        def first():
+            return lambda records: next(iter(records)) if len(records) > 1 else records


I'm afraid this may break the code:

fields.first was a function that accepted a recordset as param and returned its first record (if any)

this new implementation, instead, accepts no arguments and returns a function

Can you test this, please?
If not working, should be easy to fix:

def first(recs): return next(iter(recs)) if len(recs) > 1 else recs

etobella · 2026-09-25T13:06:46Z

@sergijPf can you review @SilvioC2C comments please?

etobella · 2026-10-02T09:54:08Z

Superseeded in #364

OCA-git-bot added this to the 19.0 milestone Mar 25, 2026

OCA-git-bot mentioned this pull request Mar 25, 2026

Migration to version 19.0 #205

Open

14 of 26 tasks

sergijPf force-pushed the 19.0-mig-edi_exchange_template_oca branch from 44d0990 to 23ff6e9 Compare May 21, 2026 10:47

OCA-git-bot added series:19.0 mod:edi_exchange_template_oca Module edi_exchange_template_oca labels May 21, 2026

simahawk and others added 21 commits June 9, 2026 09:00

Add edi_exchange_template

7519e42

[UPD] Update edi_exchange_template.pot

e348f7f

[UPD] README.rst

d03d534

edi_exchange_template 13.0.1.1.0

2d1d7f1

edi_exchange_template: minor changes

21b44dc

edi.backend: add cron to handle record state updates

7d90b4f

edi.exchange.template: update according to edi changes

bef4fb4

edi_exchange_template 13.0.1.2.0

1c2bc75

[FIX] edi_exchange_template Tests

2c382d8

edi_exchange_template 13.0.1.3.0

1ec0a5d

edi.template: fix info provider lookup

093010c

edi_exchange_template: fix tests class

f2abd73

edi_exchange_template 13.0.1.4.0

cddb6ec

edi_exchange_template: add TODO

ee910c3

edi_exchange_template: adapt lookup to new api

be9545a

edi_exchange_template 13.0.1.5.0

e26274d

[CHG] edi: Use more permissive licence: AGPL-> LGPL

9899909

edi.backend: rename generate to match others

fdd064a

All the other main methods start with 'exchange_'. Make generate respect this convention.

[UPD] README.rst

830e400

edi_exchange_template 13.0.1.5.1

2e6dc36

edi_exchange_template 13.0.1.6.0

769f43e

yankinmax and others added 18 commits June 9, 2026 09:00

edi_exchange_template: drop deprecated type_id

8954b1e

[UPD] Update edi_exchange_template_oca.pot

4b72448

[BOT] post-merge updates

eebb380

edi_exchange_template: complete specific tmpl lookup

cc04803

Fix the behavior according to the feature ported from v14 and drop the deprecated lookup by code.

edi_exchange_template: avoid using BaseCommon

59a40d8

It slows down test suites by creating too many things when not needed.

[BOT] post-merge updates

a27332f

[IMP] edi_exchange_template_oca: Adapt to new edi_core_oca logic

ec73cfe

[IMP] edi_exchange_template_oca: Pass logic to a new handler

77e1dae

[UPD] Update edi_exchange_template_oca.pot

34eee92

[BOT] post-merge updates

4124486

edi_exchange_template: fix migration to 18.0.1.3.0

58ca0b0

[BOT] post-merge updates

d6caeb8

[FIX] edi_*_oca: New way for FakeModelLoader

470b972

[BOT] post-merge updates

3cd7c4f

sergijPf force-pushed the 19.0-mig-edi_exchange_template_oca branch from 23ff6e9 to f33e03a Compare June 9, 2026 06:22

[MIG] edi_exchange_template_oca: Migration to 19.0

6f08f49

sergijPf force-pushed the 19.0-mig-edi_exchange_template_oca branch from f33e03a to 6f08f49 Compare June 9, 2026 06:40

simahawk requested changes Jun 9, 2026

View reviewed changes

[REM] edi_exchange_template_oca: get rid of dead code

69fd194

simahawk approved these changes Jun 23, 2026

View reviewed changes

simahawk reviewed Jun 23, 2026

View reviewed changes

SilvioC2C reviewed Sep 21, 2026

View reviewed changes

OCA-git-bot mentioned this pull request Oct 2, 2026

[19.0][MIG]edi_exchange_template_oca #364

Open

etobella closed this Oct 2, 2026

Navigation Menu

Repository navigation

[19.0][MIG] edi_exchange_template_oca: Migration to 19.0 - #250

[19.0][MIG] edi_exchange_template_oca: Migration to 19.0#250
sergijPf wants to merge 98 commits into
OCA:19.0from
DeineTuer-GmbH:19.0-mig-edi_exchange_template_oca

sergijPf commented Mar 25, 2026

Uh oh!

etobella commented Mar 25, 2026

Uh oh!

etobella commented Mar 25, 2026

Uh oh!

OCA-git-bot commented Mar 25, 2026

Uh oh!

etobella commented Mar 27, 2026

Uh oh!

simahawk Jun 9, 2026

Uh oh!

sergijPf Jun 10, 2026

Uh oh!

simahawk Jun 23, 2026

Uh oh!

SilvioC2C left a comment

Uh oh!

SilvioC2C Sep 21, 2026

Uh oh!

etobella commented Sep 25, 2026

Uh oh!

etobella commented Oct 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants

Conversation

sergijPf commented Mar 25, 2026

Uh oh!

etobella commented Mar 25, 2026

Uh oh!

etobella commented Mar 25, 2026

Uh oh!

OCA-git-bot commented Mar 25, 2026

Uh oh!

etobella commented Mar 27, 2026

Uh oh!

simahawk Jun 9, 2026

Choose a reason for hiding this comment

Uh oh!

sergijPf Jun 10, 2026

Choose a reason for hiding this comment

Uh oh!

simahawk Jun 23, 2026

Choose a reason for hiding this comment

Uh oh!

SilvioC2C left a comment

Choose a reason for hiding this comment

Uh oh!

SilvioC2C Sep 21, 2026

Choose a reason for hiding this comment

Uh oh!

etobella commented Sep 25, 2026

Uh oh!

etobella commented Oct 2, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

15 participants