docs: rename the gateway's keep alive values to health check - #3451
Open
flin-8 wants to merge 1 commit into
Open
docs: rename the gateway's keep alive values to health check#3451flin-8 wants to merge 1 commit into
flin-8 wants to merge 1 commit into
Conversation
flin-8
commented
Sep 7, 2026
| - The "Gateway connectivity" tab of the Argo CD instance intermittently shows "Unavailable", depending on when the last health check ran | ||
| - The gateway pod logs show stream errors followed by an immediate reconnection | ||
| - If the load balancer drops connections silently instead of closing them, the logs show failing keep alives (`keep alive check failed - cancelling subscribers` with `DeadlineExceeded` errors) and the gateway pod restart count climbs at a regular cadence | ||
| - If the load balancer drops connections silently instead of closing them, the logs show failing health checks (`keep alive check failed - cancelling subscribers` with `DeadlineExceeded` errors) and the gateway pod restart count climbs at a regular cadence |
Contributor
Author
There was a problem hiding this comment.
we need to update the keep alive check failed message
flin-8
commented
Sep 7, 2026
|
|
||
| - A load balancer or proxy between the gateway and Octopus Server closes connections it considers idle | ||
| - The gateway sends a keep alive to Octopus Server every 30 seconds by default to hold the connection open. If the load balancer's idle timeout is shorter than the keep alive interval (or keep alives are disabled), the connection is terminated before the next keep alive is sent | ||
| - The gateway sends a health check to Octopus Server every 30 seconds by default to hold the connection open. If the load balancer's idle timeout is shorter than the health check interval (or health checks are disabled), the connection is terminated before the next health check is sent |
Contributor
Author
There was a problem hiding this comment.
I thought we use gRPC keepalive to keep the connection open? Also what was the thing in AWS that forcibly closes the connection anyway?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follows the gateway chart rename in octopus-argocd-gateway#276:
gateway.octopus.keepAlive.{intervalSeconds,maxConsecutiveFailures}becamegateway.octopus.healthCheck.{interval,giveUpAfter}, and both are now duration strings rather than integers.--setexample carries the unit (interval="15s")The quoted log line stays
keep alive check failed - cancelling subscribers, which is still what the gateway logs.