fix: correct GitCredentialId JSON tag on ReleaseTemplateGitResource - #445
Open
NickJosevski wants to merge 1 commit into
Open
fix: correct GitCredentialId JSON tag on ReleaseTemplateGitResource#445NickJosevski wants to merge 1 commit into
NickJosevski wants to merge 1 commit into
Conversation
GitCredentialId was tagged NuGetPackageId, so it never deserialised and always read as empty. Add GitHubConnectionId, which the server also sends. Fixes #443 Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
NickJosevski
force-pushed
the
fix/443-git-credential-id-json-tag
branch
from
September 4, 2026 03:26
4736b78 to
1b4787c
Compare
NickJosevski
marked this pull request as ready for review
September 4, 2026 03:27
Contributor
Author
|
@YuKitsune how does this look? |
YuKitsune
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitCredentialIdwas taggedjson:"NuGetPackageId,omitempty", so it never deserialised and always read as"".GitHubConnectionId, which the server also sends, was missing from the struct.Tags now match
pkg/gitdependencies/git_dependency.go, which had them right.Verified against a live instance — the same
GetTemplatecall that returnedGitCredentialId = ""now returns"GitCredentials-1". Added unmarshal/marshal tests;pkg/releasespreviously had none.Fixes #443
🤖 Generated with Claude Code