feat: add Android floating tab bar - #104
Open
huhuanming wants to merge 1 commit into
Open
huhuanming wants to merge 1 commit into
huhuanming wants to merge 1 commit into
Conversation
originalix
reviewed
Sep 15, 2026
| floatingDragOriginalItemId = item.itemId | ||
| floatingDragCandidateItemId = item.itemId | ||
| view.isPressed = true | ||
| beginFloatingDrag(item.itemId) |
Contributor
There was a problem hiding this comment.
P2: [Selected-tab long press is swallowed in floating mode]
When androidTabBarStyle is floating, a touch on the selected tab reaches this branch and returns true from ACTION_DOWN. That prevents Android from running the item's existing OnLongClickListener; a stationary hold later falls through ACTION_UP to performClick(), so onTabLongPress never fires.
Keep a stationary-hold path that invokes performLongClick() (or let the existing long-click listener own that gesture), and consume the sequence for drag only after movement has activated the drag gesture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
androidTabBarStyleprop withdefaultandfloatingmodesValidation
yarn workspace @onekeyfe/react-native-tab-view typecheckyarn workspace @onekeyfe/react-native-tab-view prepareJAVA_HOME=$(/usr/libexec/java_home -v 17) ANDROID_HOME=/Users/huhuanming/Library/Android/sdk ./gradlew :onekeyfe_react-native-tab-view:compileDebugKotlingit diff --checkNotes
eslintcommand in this workspace; no lint dependency or unrelated configuration was changed in this PR.