-
Notifications
You must be signed in to change notification settings - Fork 3
feat(native-list): add listStyle for separator and group chrome #112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: codex/native-list-row-style-example
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -500,6 +500,7 @@ class NativeListView( | |
| usesSelectorSourceScale = next.items.any { it.usesSelectorSourceScale } | ||
| adapter.usesSelectorSourceScale = usesSelectorSourceScale | ||
| adapter.theme = next.theme | ||
| adapter.listStyle = next.listStyle | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. P2: [Android initial snapshots never pass listStyle to rows] On the normal snapshot path, including first mount, the adapter receives theme, layout, and orientation but not Assign |
||
| adapter.layout = next.layout | ||
| adapter.orientation = next.orientation | ||
| adapter.selectedKeys = next.selectedKeys | ||
|
|
@@ -1381,6 +1382,7 @@ class NativeListView( | |
| footerView.recycle() | ||
| } else { | ||
| footerView.visibility = VISIBLE | ||
| footerView.listStyle = next.listStyle | ||
| footerView.bind( | ||
| footer, | ||
| next.theme, | ||
|
|
||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
P2: [Android applies groupCornerRadius outside groupId cards]
When a snapshot sets
groupCornerRadius,applySelectionStatesynthesizessinglefor wallet-sidebar, sized selector, and metric-card rows even when they have nogroupId.groupedBackgroundthen applies the configured radius to those rows. iOS and Web consume the serializedgroupPosition, so this creates Android-only geometry changes outside the documented grouped-card surface.Gate the custom radius on actual
groupIdmembership (or pass an explicit grouped-card flag), while preserving each non-group template's existing radius, and cover these selector and metric-card variants.