Skip to content

fix: classic hydration takes the leaf's one chunk - #361

Merged
suguanYang merged 3 commits into
mainfrom
fix/wuchengke/classic-primary-chunk-no-asset-fallback
Aug 31, 2026
Merged

fix: classic hydration takes the leaf's one chunk#361
suguanYang merged 3 commits into
mainfrom
fix/wuchengke/classic-primary-chunk-no-asset-fallback

Conversation

@EricNGOntos

@EricNGOntos EricNGOntos commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Summary

  • A leaf owns one chunk. Classic hydration now takes that chunk by section; it no longer loops to pick the first non-image/table row.
  • Images and tables still enter through connect_to.
  • Discovery failures still raise instead of becoming empty results.

Test plan

  • make check green locally
  • Remote CI green after this push
  • Classic retrieval (use_agentic=false) returns the leaf's text chunk
  • Image/table-only requests still resolve via connect_to

EricNGOntos and others added 3 commits August 31, 2026 21:34
A content section owns one non-asset chunk; assets only enter results via
connect_to. Also stop swallowing discovery failures into empty results.

Co-authored-by: Cursor <cursoragent@cursor.com>
A leaf owns one chunk; images and tables attach through connect_to.
Remove the first-non-asset loop left from the previous hydration pass.

Co-authored-by: Cursor <cursoragent@cursor.com>
@EricNGOntos EricNGOntos changed the title fix: classic discovery must not return assets as primary hits fix: classic hydration takes the leaf's one chunk Aug 31, 2026
@suguanYang
suguanYang merged commit 6905951 into main Aug 31, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants