Skip to content

perf: avoid repeated section scans in map discovery #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
suguanYang merged 1 commit into from
Sep 1, 2026
Merged

perf: avoid repeated section scans in map discovery #367

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 39 additions & 2 deletions packages/shared-python/shared/services/retrieval/search/map_unit_discovery.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,25 @@
)
"""

_SCOPED_UNIT_IDS_CTE = """
WITH scoped_units AS (
SELECT
dmu.id AS map_unit_id,
dmu.document_id,
dmu.job_result_id
FROM document_map_units dmu
JOIN documents d
ON d.document_id = dmu.document_id
{revision_join}
WHERE d.user_id = :user_id
AND d.namespace = :namespace
AND d.status = 'active'
{revision_clause}
{exclude_clause}
{type_clause}
)
"""


@dataclass
class DiscoveryResult:
Expand Down Expand Up @@ -287,7 +306,16 @@ async def map_unit_discovery(

frequency_result = await db.execute(
text(
cte
(
cte
if signal_paths
else _SCOPED_UNIT_IDS_CTE.format(
revision_join=revision_join,
revision_clause=revision_clause,
exclude_clause=exclude_clause,
type_clause=type_clause,
)
)
+ """
SELECT tokens.map_unit_id, tokens.channel, tokens.token, tokens.frequency
FROM document_map_unit_tokens AS tokens
Expand All @@ -310,7 +338,16 @@ async def map_unit_discovery(

index_result = await db.execute(
text(
cte
(
cte
if signal_paths
else _SCOPED_UNIT_IDS_CTE.format(
revision_join=revision_join,
revision_clause=revision_clause,
exclude_clause=exclude_clause,
type_clause=type_clause,
)
)
+ """
SELECT indexes.average_idf_path, indexes.average_idf_content,
indexes.unit_count
Expand Down
Loading